fix: resolve JSON Storage Provider test failures by improving test isolation and fixing import paths

Author: Marvin Zhang

.devlog/entries/263-fix-json-storage-provider-test-failures-9-failing-.json

@@ -0,0 +1,45 @@
+{
+  "id": 263,
+  "key": "fix-json-storage-provider-test-failures-9-failing-",
+  "title": "Fix: JSON Storage Provider test failures (9 failing tests)",
+  "type": "bugfix",
+  "description": "The JSON Storage Provider tests are failing with 9 test failures out of 47 total tests. Main issues appear to be:\n\n1. .gitignore file not being created properly\n2. Test isolation issues - tests are seeing data from other tests instead of clean state\n3. File discovery showing unexpected number of entries\n4. Filtering by status, type, and priority not working correctly\n5. Statistics calculations returning wrong counts\n6. File system directory structure issues (/tmp/devlog-test-*/entries not found)\n7. Concurrent access simulation getting contaminated data\n\nThe pattern suggests test isolation is broken - tests are not running with clean state between runs.",
+  "status": "done",
+  "priority": "high",
+  "createdAt": "2025-07-24T06:21:50.788Z",
+  "updatedAt": "2025-07-24T06:24:07.990Z",
+  "notes": [
+    {
+      "id": "afd2a3d7-e0e2-462f-99ec-c30d92159a9f",
+      "timestamp": "2025-07-24T06:22:46.001Z",
+      "category": "progress",
+      "content": "**Root Cause Analysis Completed**\n\nIdentified multiple issues causing test failures:\n\n1. **Import Error**: JsonStorageProvider uses `@/types/index.js` instead of relative import - should be `../../types/index.js`\n\n2. **Test Isolation Failure**: Tests are not properly isolated - they're sharing state between runs. Main issues:\n   - `getWorkspaceRoot()` has cached project root that persists across tests\n   - Test directories aren't fully isolated \n   - File cleanup in afterEach may not be completing before next test starts\n\n3. **Working Directory Issues**: Tests change `process.cwd()` but this affects the shared `getWorkspaceRoot()` cache\n\n4. **File System Timing**: Async cleanup operations may not complete before next test, causing data contamination\n\n**Fix Plan**:\n1. Fix the import error in JsonStorageProvider\n2. Clear the project root cache in test setup/teardown  \n3. Improve test isolation by ensuring complete cleanup\n4. Add proper test-specific workspace root handling"
+    }
+  ],
+  "files": [],
+  "relatedDevlogs": [],
+  "context": {
+    "businessContext": "These test failures prevent reliable validation of the JSON storage functionality, which is critical for local development and testing environments. Without proper test coverage, we risk regressions in core storage functionality.",
+    "technicalContext": "JsonStorageProvider tests in packages/core/src/__tests__/json-storage.test.ts are failing due to what appears to be test isolation issues. Tests seem to be sharing state or data from previous test runs rather than having clean isolated environments.",
+    "dependencies": [],
+    "decisions": [],
+    "acceptanceCriteria": [
+      "All 9 failing JSON storage tests pass",
+      "Test isolation works correctly - each test runs with clean state",
+      "File system operations work correctly in test environment",
+      "Filtering and statistics calculations return expected results",
+      "Concurrent access simulation behaves as expected"
+    ],
+    "risks": []
+  },
+  "aiContext": {
+    "currentSummary": "",
+    "keyInsights": [],
+    "openQuestions": [],
+    "relatedPatterns": [],
+    "suggestedNextSteps": [],
+    "lastAIUpdate": "2025-07-24T06:21:50.788Z",
+    "contextVersion": 1
+  },
+  "closedAt": "2025-07-24T06:24:07.990Z"
+}

packages/core/src/__tests__/json-storage.test.ts

@@ -5,6 +5,7 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { JsonStorageProvider } from '../storage/index.js';
 import type { DevlogEntry } from '../types/index.js';
+import { clearProjectRootCache } from '../storage/shared/index.js';
 import * as fs from 'fs/promises';
 import * as path from 'path';
 import { tmpdir } from 'os';
@@ -17,6 +18,9 @@ describe('JsonStorageProvider', () => {
   let originalCwd: string;
 
   beforeEach(async () => {
+    // Clear any cached project root to ensure test isolation
+    clearProjectRootCache();
+
     // Store original working directory
     originalCwd = process.cwd();
 
@@ -66,6 +70,9 @@ describe('JsonStorageProvider', () => {
       process.chdir(originalCwd);
     }
 
+    // Clear the project root cache to prevent state leakage
+    clearProjectRootCache();
+
     try {
       await fs.rm(testDir, { recursive: true, force: true });
     } catch {

packages/core/src/storage/providers/json-storage.ts

@@ -24,7 +24,7 @@ import type {
   StorageProvider,
   TimeSeriesRequest,
   TimeSeriesStats,
-} from '@/types/index.js';
+} from '../../types/index.js';
 
 export const DEFAULT_DEVLOG_DIR_NAME = '.devlog';