Skip to content

Commit 7f78bf6

Browse files
Copilottikazyq
andcommitted
fix: Address code review feedback
- Fix PostgreSQL JSONB operator documentation (@? doesn't exist) - Fix relative documentation paths in PHASE2_IMPLEMENTATION.md - Use repository-root relative paths for better navigation Co-authored-by: tikazyq <[email protected]>
1 parent 76d6a0d commit 7f78bf6

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

prisma/migrations/20251101000000_add_timescaledb_composite_indexes/migration.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ CREATE INDEX "agent_events_project_id_timestamp_idx" ON "agent_events"("project_
2626
CREATE INDEX "agent_events_data_idx" ON "agent_events" USING GIN ("data");
2727

2828
-- Note: The `data` field uses the default GIN operator class (jsonb_ops),
29-
-- which supports containment queries (@>, @?, etc.) but uses more storage.
29+
-- which supports containment queries (@>, <@) and existence queries (?, ?|, ?&).
3030
-- Alternative: jsonb_path_ops uses less storage but only supports @> operator.
3131
-- The default is chosen for maximum query flexibility.

specs/20251031/001-database-architecture/PHASE2_IMPLEMENTATION.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,10 @@ _To be measured after production deployment_:
320320

321321
## 📚 Related Documentation
322322

323-
- [Database Architecture Spec](../../specs/20251031/001-database-architecture/README.md) - Full specification
324-
- [Phase 1 Implementation](../../specs/20251031/001-database-architecture/IMPLEMENTATION_SUMMARY.md) - TimescaleDB setup
325-
- [Prisma Schema](../../prisma/schema.prisma) - Updated schema file
326-
- [Migration File](../../prisma/migrations/20251101000000_add_timescaledb_composite_indexes/migration.sql) - Index migration
323+
- [Database Architecture Spec](./README.md) - Full specification
324+
- [Phase 1 Implementation](./IMPLEMENTATION_SUMMARY.md) - TimescaleDB setup
325+
- [Prisma Schema](/prisma/schema.prisma) - Updated schema file
326+
- [Migration File](/prisma/migrations/20251101000000_add_timescaledb_composite_indexes/migration.sql) - Index migration
327327

328328
---
329329

@@ -339,4 +339,4 @@ _To be measured after production deployment_:
339339

340340
**Phase 2 Status**: ✅ Complete
341341
**Implementation Date**: November 1, 2025
342-
**Next Phase**: Phase 3 - Optimize Queries (specs/20251031/001-database-architecture/README.md)
342+
**Next Phase**: Phase 3 - Optimize Queries (see [Database Architecture Spec](./README.md))

0 commit comments

Comments
 (0)