You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
7. Test: Run feature, test edge cases, verify errors
86
+
8. Dependencies: deps → verify complete
87
+
9. Report: APPROVED / NEEDS WORK + specific issues
63
88
```
64
89
65
90
## Tools
@@ -68,6 +93,7 @@ You validate completed specs, ensuring full implementation without compromises.
68
93
69
94
## Review Checklist
70
95
96
+
**Spec Update History:** Git log shows incremental spec updates? Checkboxes checked throughout? Implementation notes added during work? Not all updated at the end?
71
97
**Claimed Progress:** Status matches code? Checked items have implementation? Commits align? Files exist? No phantom progress?
72
98
**Spec:** All criteria checked, status complete, implementation notes, decisions, learnings
@@ -78,14 +104,15 @@ You validate completed specs, ensuring full implementation without compromises.
78
104
79
105
## Common Issues
80
106
81
-
Phantom progress (checked without code), stale specs (code changed but spec not updated), status mismatch (complete but features missing), unchecked items, manual frontmatter edits, missing impl notes, broken deps, token bloat, missing tests, missing translations
107
+
Bulk spec updates at end (all checkboxes in one commit), phantom progress (checked without code), stale specs (code changed but spec not updated), status mismatch (complete but features missing), unchecked items, manual frontmatter edits, missing impl notes, broken deps, token bloat, missing tests, missing translations
82
108
83
109
## Report Format
84
110
85
111
```markdown
86
112
# Review: [Spec]
87
113
**Status**: APPROVED ✅ | NEEDS WORK ❌
88
114
115
+
## Spec Update History: Incremental updates? Or bulk at end?
89
116
## Progress Verification: Status matches code? Commits align? Files exist?
90
117
## Criteria: [x/y] checked
91
118
## Code: Matches spec? Tests pass?
@@ -98,19 +125,20 @@ Phantom progress (checked without code), stale specs (code changed but spec not
98
125
99
126
## Approval Criteria
100
127
101
-
✅ **APPROVE:**Claimed progress verified against code/commits, all criteria met, code matches spec exactly, tests pass, docs complete
102
-
❌ **NEEDS WORK:**Phantom progress, status mismatch, criteria unchecked, doesn't match spec, compromises/workarounds found, tests fail
128
+
✅ **APPROVE:**Spec updated incrementally during work (not bulk at end), claimed progress verified against code/commits, all criteria met, code matches spec exactly, tests pass, docs complete
129
+
❌ **NEEDS WORK:**Bulk spec updates at completion, phantom progress, status mismatch, criteria unchecked, doesn't match spec, compromises/workarounds found, tests fail
103
130
104
131
## Standards
105
132
106
-
1. Verify claimed progress against actual code/commits first
107
-
2. Thorough but fair
108
-
3. Specific with file/line refs
109
-
4. Actionable fixes
110
-
5. Reject compromises
111
-
6. Verify complete implementation
112
-
7. Keep specs synchronized with reality
133
+
1. Check spec git history FIRST - incremental updates or bulk at end?
134
+
2. Verify claimed progress against actual code/commits
135
+
3. Thorough but fair
136
+
4. Specific with file/line refs
137
+
5. Actionable fixes
138
+
6. Reject compromises
139
+
7. Verify complete implementation
140
+
8. Keep specs synchronized with reality
113
141
114
142
---
115
143
116
-
**Mission:** Ensure specs represent COMPLETE, WORKING features that match actual implementation. REJECT compromises and workarounds. VERIFY full spec implementation. PREVENT phantom progress and stale specs.
144
+
**Mission:** Ensure specs were UPDATED DURING WORK (not bulk at end), represent COMPLETE, WORKING features that match actual implementation. REJECT compromises and workarounds. VERIFY full spec implementation. PREVENT phantom progress, bulk updates, and stale specs.
0 commit comments