fix: proper window.location redirects for cloud sandboxes and branches (#6994)

Author: alexnm

packages/app/src/app/pages/Dashboard/Components/Sandbox/index.tsx

@@ -198,7 +198,11 @@ const GenericSandbox = ({ isScrolling, item, page }: GenericSandboxProps) => {
       if (sandboxAnalyticsEvent) {
         trackImprovedDashboardEvent(sandboxAnalyticsEvent);
       }
-      history.push(url);
+      if (sandbox.isV2) {
+        window.location.href = url;
+      } else {
+        history.push(url);
+      }
     }
   };
 

packages/app/src/app/pages/Dashboard/Components/Selection/ContextMenus/BranchMenu.tsx

@@ -5,15 +5,13 @@ import {
   githubRepoUrl,
   v2BranchUrl,
 } from '@codesandbox/common/lib/utils/url-generator';
-import { useHistory } from 'react-router-dom';
 import { Context, MenuItem } from '../ContextMenu';
 
 type BranchMenuProps = {
   branch: Branch;
 };
 export const BranchMenu: React.FC<BranchMenuProps> = ({ branch }) => {
   const { visible, setVisibility, position } = React.useContext(Context);
-  const history = useHistory();
 
   const { name, project, contribution } = branch;
   const branchUrl = v2BranchUrl({ name, project });
@@ -31,7 +29,13 @@ export const BranchMenu: React.FC<BranchMenuProps> = ({ branch }) => {
       position={position}
       style={{ width: 120 }}
     >
-      <MenuItem onSelect={() => history.push(branchUrl)}>Open branch</MenuItem>
+      <MenuItem
+        onSelect={() => {
+          window.location.href = branchUrl;
+        }}
+      >
+        Open branch
+      </MenuItem>
       <MenuItem onSelect={() => window.open(branchUrl, '_blank')}>
         Open branch in a new tab
       </MenuItem>

packages/app/src/app/pages/Dashboard/Components/Selection/ContextMenus/SandboxMenu.tsx

@@ -127,7 +127,17 @@ export const SandboxMenu: React.FC<SandboxMenuProps> = ({
           Fork Template
         </MenuItem>
       ) : null}
-      <MenuItem onSelect={() => history.push(url)}>Open {label}</MenuItem>
+      <MenuItem
+        onSelect={() => {
+          if (sandbox.isV2) {
+            window.location.href = url;
+          } else {
+            history.push(url);
+          }
+        }}
+      >
+        Open {label}
+      </MenuItem>
       <MenuItem
         onSelect={() => {
           window.open(`https://codesandbox.io${url}`, '_blank');