Skip to content

Commit a26843d

Browse files
authored
chore: add helper for docs links (#6998)
1 parent 743b163 commit a26843d

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

packages/app/src/app/pages/common/UserMenu/index.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
dashboardUrl,
44
profileUrl,
55
searchUrl,
6+
docsUrl,
67
} from '@codesandbox/common/lib/utils/url-generator';
78
import { Menu, Stack, Element, Icon, Text } from '@codesandbox/components';
89
import { useAppState, useActions } from 'app/overmind';
@@ -67,7 +68,7 @@ export const UserMenu: FunctionComponent & {
6768
</Stack>
6869
</Menu.Link>
6970

70-
<Menu.Link href="/docs">
71+
<Menu.Link href={docsUrl()}>
7172
<Stack align="center" gap={2}>
7273
<Icon name="documentation" size={16} />
7374
<Text>Documentation</Text>
@@ -91,7 +92,7 @@ export const UserMenu: FunctionComponent & {
9192
)}
9293

9394
{showBecomePro && (
94-
<Menu.Link href="/pro">
95+
<Menu.Link to="/pro">
9596
<Stack align="center" gap={2}>
9697
<Icon name="proBadge" size={16} />
9798
<Text>Upgrade to Pro</Text>
@@ -102,7 +103,7 @@ export const UserMenu: FunctionComponent & {
102103
<Menu.Divider />
103104

104105
{showManageSubscription && (
105-
<Menu.Link href={`/dashboard/settings?workspace=${activeTeam}`}>
106+
<Menu.Link to={`/dashboard/settings?workspace=${activeTeam}`}>
106107
<Stack align="center" gap={2}>
107108
<Icon name="proBadge" size={16} />
108109
<Text>Subscription</Text>

packages/common/src/utils/url-generator.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,9 @@ export function getSandboxId() {
295295
return result;
296296
}
297297

298+
export const docsUrl = (path: string = '') =>
299+
`https://codesandbox.io/docs${path}`;
300+
298301
export const teamInviteLink = (inviteToken: string) =>
299302
`${protocolAndHost()}/invite/${inviteToken}`;
300303

packages/components/src/components/Menu/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,13 @@ const MenuLink: React.FunctionComponent<MenuLinkProps> = ({
302302
);
303303
}
304304
return (
305-
<ReachMenu.MenuLink data-component="MenuLink" href={href} title={title}>
305+
<ReachMenu.MenuLink
306+
data-component="MenuLink"
307+
href={href}
308+
target="_blank"
309+
rel="noopener noreferrer"
310+
title={title}
311+
>
306312
{children}
307313
</ReachMenu.MenuLink>
308314
);

0 commit comments

Comments
 (0)