tweak: list api (#40)

Author: CompuIves

src/bin/commands/sandbox/list.ts

@@ -45,7 +45,7 @@ export async function listSandboxes(
   outputFields?: string,
   listOpts: SandboxListOpts & { pagination?: PaginationOpts } = {},
   showHeaders = true,
-  limit?: number
+  limit = 100
 ) {
   const sdk = new CodeSandbox();
   const spinner = ora("Fetching sandboxes...").start();
@@ -63,7 +63,6 @@ export async function listSandboxes(
         pagination,
       } = await sdk.sandbox.list({
         ...listOpts,
-        limit: undefined, // Force pagination so we can show progress
         pagination: {
           page: currentPage,
           pageSize,
@@ -86,11 +85,11 @@ export async function listSandboxes(
       })`;
 
       // Stop if we've reached the total count
-      if (allSandboxes.length >= totalCount) {
+      if (allSandboxes.length >= limit || pagination.nextPage == null) {
         break;
       }
 
-      currentPage++;
+      currentPage = pagination.nextPage;
     }
 
     // Apply limit after fetching all sandboxes

src/sandbox-client.ts

@@ -394,7 +394,7 @@ export class SandboxClient {
    * This method supports two modes of operation:
    * 1. Simple limit-based fetching (default):
    *    ```ts
-   *    // Get up to 100 sandboxes (default)
+   *    // Get up to 50 sandboxes (default)
    *    const { sandboxes, totalCount } = await client.list();
    *
    *    // Get up to 200 sandboxes
@@ -423,10 +423,10 @@ export class SandboxClient {
       pagination?: PaginationOpts;
     } = {}
   ): Promise<SandboxListResponse> {
-    const limit = opts.limit ?? 100;
+    const limit = opts.limit ?? 50;
     let allSandboxes: SandboxInfo[] = [];
     let currentPage = opts.pagination?.page ?? 1;
-    let pageSize = opts.pagination?.pageSize ?? 50;
+    let pageSize = opts.pagination?.pageSize ?? limit;
     let totalCount = 0;
     let nextPage: number | null = null;
 
@@ -457,11 +457,14 @@ export class SandboxClient {
         tags: sandbox.tags,
       }));
 
-      allSandboxes = [...allSandboxes, ...sandboxes];
+      const newSandboxes = sandboxes.filter(
+        (sandbox) =>
+          !allSandboxes.some((existing) => existing.id === sandbox.id)
+      );
+      allSandboxes = [...allSandboxes, ...newSandboxes];
 
       // Stop if we've hit the limit or there are no more pages
       if (!nextPage || allSandboxes.length >= limit) {
-        allSandboxes = allSandboxes.slice(0, limit);
         break;
       }