Skip to content

Commit 528022e

Browse files
authored
fix: CommonJS build requires .cjs extension for ESM package (#56)
1 parent 23d1469 commit 528022e

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

esbuild.cjs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ Promise.all([
2424
entryPoints: ["src/browser.ts"],
2525
bundle: true,
2626
format: "cjs",
27-
outdir: "dist/cjs",
27+
// .cjs extension is required because "type": "module" is set in package.json
28+
outfile: "dist/cjs/browser.cjs",
2829
platform: "browser",
2930
plugins: [browserifyPlugin],
3031
}),
@@ -47,7 +48,8 @@ Promise.all([
4748
bundle: true,
4849
format: "cjs",
4950
platform: "node",
50-
outdir: "dist/cjs",
51+
// .cjs extension is required because "type": "module" is set in package.json
52+
outfile: "dist/cjs/index.cjs",
5153
plugins: [browserifyPlugin],
5254
}),
5355

@@ -64,15 +66,16 @@ import { createRequire as topLevelCreateRequire } from 'module';
6466
const require = topLevelCreateRequire(import.meta.url);
6567
`.trim(),
6668
},
67-
outdir: "dist/esm",
69+
outfile: "dist/esm/index.js",
6870
plugins: [browserifyPlugin],
6971
}),
7072

7173
// Edge:
7274
// CommonJS build
7375
esbuild.build({
7476
entryPoints: ["src/index.ts"],
75-
outfile: "dist/cjs/index.edge.js",
77+
// .cjs extension is required because "type": "module" is set in package.json
78+
outfile: "dist/cjs/index.edge.cjs",
7679
bundle: true,
7780
format: "cjs",
7881
platform: "browser",

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
"types": "./dist/esm/index.d.ts",
2121
"edge-light": {
2222
"import": "./dist/esm/index.edge.js",
23-
"require": "./dist/cjs/index.edge.js",
24-
"default": "./dist/cjs/index.edge.js"
23+
"require": "./dist/cjs/index.edge.cjs",
24+
"default": "./dist/cjs/index.edge.cjs"
2525
},
2626
"worker": {
2727
"import": "./dist/esm/index.edge.js",
@@ -39,13 +39,14 @@
3939
"default": "./dist/cjs/index.edge.js"
4040
},
4141
"import": "./dist/esm/index.js",
42-
"require": "./dist/cjs/index.js",
43-
"default": "./dist/cjs/index.js"
42+
"require": "./dist/cjs/index.cjs",
43+
"default": "./dist/cjs/index.cjs"
4444
},
4545
"./browser": {
4646
"types": "./dist/esm/browser.d.ts",
4747
"import": "./dist/esm/browser.js",
48-
"require": "./dist/cjs/browser.js"
48+
"require": "./dist/cjs/browser.cjs",
49+
"default": "./dist/cjs/browser.cjs"
4950
}
5051
},
5152
"types": "./dist/esm/index.d.ts",

0 commit comments

Comments
 (0)