fix: validate gridNet in NewClient and add logging for state management

Author: SalmaElsoly

backend/internal/deployment/kubedeployer/client.go

@@ -1,6 +1,7 @@
 package kubedeployer
 
 import (
+	"fmt"
 	"kubecloud/internal/infrastructure/gridclient"
 
 	sdktrace "go.opentelemetry.io/otel/sdk/trace"
@@ -12,10 +13,11 @@ type Client struct {
 
 // NewClient creates a new Client instance
 func NewClient(mnemonic, gridNet string, debug bool, tp *sdktrace.TracerProvider) (*Client, error) {
-	var opts []gridclient.ClientOpts
-	if gridNet != "" {
-		opts = append(opts, gridclient.WithNetwork(gridNet))
+	if gridNet == "" {
+		return nil, fmt.Errorf("gridNet is required and cannot be empty")
 	}
+	var opts []gridclient.ClientOpts
+	opts = append(opts, gridclient.WithNetwork(gridNet))
 	if debug {
 		opts = append(opts, gridclient.WithDebug())
 	}

backend/internal/deployment/statemanager/gridclient_state.go

@@ -2,6 +2,7 @@ package statemanager
 
 import (
 	"kubecloud/internal/deployment/kubedeployer"
+	"kubecloud/internal/infrastructure/logger"
 
 	"github.com/xmonader/ewf"
 )
@@ -10,12 +11,16 @@ const gridClientStateKey = "gridclient_state"
 
 // SaveGridClientState saves the GridClient state to the workflow state
 func SaveGridClientState(workflowState ewf.State, kubeClient *kubedeployer.Client) {
+	log := logger.ForOperation("statemanager", "save_gridclient_state")
+
 	if kubeClient == nil || kubeClient.GridClient == nil {
+		log.Warn().Msg("kubeClient or GridClient is nil, skipping state save")
 		return
 	}
 
 	stateData, err := kubeClient.GridClient.GetState()
 	if err != nil {
+		log.Warn().Err(err).Msg("Failed to get GridClient state")
 		return
 	}
 

backend/internal/infrastructure/gridclient/grid_client.go

@@ -11,6 +11,7 @@ import (
 	"kubecloud/internal/infrastructure/logger"
 	"math"
 	"net/http"
+	"sync"
 	"time"
 
 	"github.com/cosmos/go-bip39"
@@ -79,6 +80,7 @@ type GridClient interface {
 type gridClient struct {
 	gridClient     *deployer.TFPluginClient
 	systemMnemonic string
+	mu             sync.RWMutex
 }
 
 var _ GridClient = (*gridClient)(nil)

backend/internal/infrastructure/gridclient/grid_client_state.go

@@ -15,6 +15,9 @@ type gridClientState struct {
 
 // GetState returns the current GridClient state as JSON bytes
 func (s *gridClient) GetState() ([]byte, error) {
+	s.mu.RLock()
+	defer s.mu.RUnlock()
+
 	if s.gridClient.State == nil {
 		return nil, fmt.Errorf("gridclient state is nil")
 	}
@@ -39,6 +42,9 @@ func (s *gridClient) GetState() ([]byte, error) {
 
 // RestoreState restores the GridClient state from JSON bytes
 func (s *gridClient) RestoreState(stateData []byte) error {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
 	if s.gridClient.State == nil {
 		return fmt.Errorf("gridclient state is nil")
 	}