Add duplicate check for node ID assignment in cluster (#603)

* feat: add duplicate check for node ID assignment in cluster

* fix: prevent assigning VMs to nodes already assigned within a cluster

---------

Co-authored-by: kassem <omarksm09@gmail.com>

Author: SalmaElsoly

backend/app/deployment_handler.go

@@ -503,6 +503,11 @@ func (h *Handler) HandleAddNode(c *gin.Context) {
 			c.JSON(http.StatusConflict, gin.H{"error": "Node with the same name already exists"})
 			return
 		}
+
+		if node.NodeID == cluster.Nodes[0].NodeID {
+			c.JSON(http.StatusConflict, gin.H{"error": fmt.Sprintf("node id %d is already assigned to this cluster", node.NodeID)})
+			return
+		}
 	}
 
 	wf, err := h.ewfEngine.NewWorkflow(constants.WorkflowAddNode)

backend/kubedeployer/types.go

@@ -313,11 +313,17 @@ func (c *Cluster) UnmarshalJSON(data []byte) error {
 
 func (c *Cluster) Validate() error {
 	nodeNames := make(map[string]struct{})
+	nodeIDs := make(map[uint32]struct{})
 	for _, node := range c.Nodes {
 		if _, exists := nodeNames[node.Name]; exists {
 			return fmt.Errorf("duplicate node name found: %s", node.Name)
 		}
 		nodeNames[node.Name] = struct{}{}
+
+		if _, exists := nodeIDs[node.NodeID]; exists {
+			return fmt.Errorf("duplicate node id found: %d", node.NodeID)
+		}
+		nodeIDs[node.NodeID] = struct{}{}
 	}
 
 	return nil

frontend/kubecloud/src/components/dashboard/EditClusterNodesDialog.vue

@@ -187,7 +187,8 @@ const availableNodes = computed<RawNode[]>(() => {
   return nodes.value.filter((node: RawNode) => {
     const availRAM = getAvailableRAM(node)
     const availStorage = getAvailableStorage(node)
-    return availRAM > 0 && availStorage > 0
+    const nodeIsNotInCluster = !clusterNodes.value.some((clusterNode: any) => clusterNode.node_id === node.nodeId)
+    return availRAM > 0 && availStorage > 0 && nodeIsNotInCluster
   })
 })
 

frontend/kubecloud/src/components/deploy/Step2AssignNodes.vue

@@ -181,6 +181,10 @@ const getAvailableNodesForVM = (vmIndex: number) => {
   const requiredStorage = (vm.disk || 0) + vm.rootfs;
 
   return props.availableNodes.filter(node => {
+    const nodeIsNotInCluster = !props.allVMs.some((vm: any) => vm.node === node.nodeId);
+    if(!nodeIsNotInCluster &&  vm.node !== node.nodeId){
+      return false;
+    }
     const vmResources = vm.node === node.nodeId ? { ram: vm.ram, storage: requiredStorage } : undefined;
     const available = getNodeResources(node, vmResources);
     return available.cpu >= vm.vcpu && available.ram >= vm.ram && available.storage >= requiredStorage;