refactor: extract URL validation into util class

Author: codescape

docs/changelog.md

@@ -18,6 +18,7 @@ category: Administration
 * refactor: use parameterized log messages
 * refactor: remove unused or obsolete imports
 * feat: ensure compatibility with Jira 11.2.0
+* refactor: extract URL validation into util class
 
 ### [25.10.0] -  2025-10-03
 

src/main/java/de/codescape/jira/plugins/multiplesubtasks/service/SubtasksCreationService.java

@@ -36,12 +36,10 @@
 import de.codescape.jira.plugins.multiplesubtasks.service.syntax.DateTimeStringService;
 import de.codescape.jira.plugins.multiplesubtasks.service.syntax.EstimateStringService;
 import de.codescape.jira.plugins.multiplesubtasks.service.syntax.SubtasksSyntaxService;
+import de.codescape.jira.plugins.multiplesubtasks.util.URLUtil;
 import jakarta.inject.Inject;
 import org.springframework.stereotype.Component;
 
-import java.net.MalformedURLException;
-import java.net.URISyntaxException;
-import java.net.URL;
 import java.sql.Timestamp;
 import java.util.*;
 import java.util.stream.Collectors;
@@ -607,7 +605,7 @@ private void applyValuesToCustomField(MutableIssue parent, MutableIssue newSubta
                                 newSubtask.setCustomFieldValue(customField, parent.getCustomFieldValue(customField));
                             }
                         } else {
-                            if (isValidURL(value)) {
+                            if (URLUtil.isValidURL(value)) {
                                 newSubtask.setCustomFieldValue(customField, value);
                             } else {
                                 warnings.add("Invalid url value for custom field: " + customFieldName);
@@ -877,16 +875,4 @@ private void applyValuesToCustomField(MutableIssue parent, MutableIssue newSubta
         }
     }
 
-    /**
-     * Verify the provided URL string is a valid URL to be persisted to a custom field of type URL.
-     */
-    private boolean isValidURL(String url) {
-        try {
-            new URL(url).toURI();
-            return true;
-        } catch (MalformedURLException | URISyntaxException e) {
-            return false;
-        }
-    }
-
 }

src/main/java/de/codescape/jira/plugins/multiplesubtasks/util/URLUtil.java

@@ -0,0 +1,25 @@
+package de.codescape.jira.plugins.multiplesubtasks.util;
+
+import java.net.MalformedURLException;
+import java.net.URI;
+import java.net.URISyntaxException;
+
+/**
+ * Utility class for URL related stuff.
+ */
+public class URLUtil {
+
+    /**
+     * Verify the provided URL string is a valid URL to be persisted to a custom field of type URL.
+     */
+    public static boolean isValidURL(String url) {
+        try {
+            //noinspection ResultOfMethodCallIgnored
+            new URI(url).toURL();
+            return true;
+        } catch (MalformedURLException | URISyntaxException | IllegalArgumentException e) {
+            return false;
+        }
+    }
+
+}

src/test/java/de/codescape/jira/plugins/multiplesubtasks/util/URLUtilTest.java

@@ -0,0 +1,21 @@
+package de.codescape.jira.plugins.multiplesubtasks.util;
+
+import org.junit.Test;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
+
+public class URLUtilTest {
+
+    @Test
+    public void shouldAcceptFullQualifiedURLs() {
+        assertThat(URLUtil.isValidURL("https://www.codescape.de"), is(equalTo(true)));
+    }
+
+    @Test
+    public void shouldRejectNonValidURLs() {
+        assertThat(URLUtil.isValidURL("stefan@codescape.de"), is(equalTo(false)));
+    }
+
+}