columns

Author: libargutxi

src/cs_dynamicpages/controlpanels/dynamica_pages_control_panel/controlpanel.py

@@ -27,7 +27,7 @@ class IRowTypeFieldsSchema(Interface):
 
     row_type_has_featured_add_button = schema.Bool(
         title="Has featured add button",
-        required=True,
+        required=False,
         default=False,
     )
 
@@ -70,7 +70,7 @@ class IDynamicaPagesControlPanel(Interface):
                 "row_type_has_featured_add_button": True,
             },
             {
-                "row_type": "cs_dynamicpages-query-three-columns-view",
+                "row_type": "cs_dynamicpages-query-columns-view",
                 "each_row_type_fields": ["IBasic.title", "ICollection.query", "ICollection.sort_on", "ICollection.sort_order", "ICollection.betweeen", "ICollection.limit"],
                 "row_type_has_featured_add_button": False,
             },

src/cs_dynamicpages/profiles/default/types/DynamicPageRow.xml

@@ -49,6 +49,7 @@
     <element value="plone.locking" />
     <element value="cs_dynamicpages.link_info" />
     <element value="cs_dynamicpages.related_image" />
+    <element value="cs_dynamicpages.row_columns" />
     <element value="plone.collection" />
     <element value="plone.constraintypes" />
     <!--<element value="plone.leadimage"/>-->

src/cs_dynamicpages/tests/test_view_query_three_columns_view.py

@@ -1,6 +1,6 @@
 from cs_dynamicpages.testing import CS_DYNAMICPAGES_FUNCTIONAL_TESTING
 from cs_dynamicpages.testing import CS_DYNAMICPAGES_INTEGRATION_TESTING
-from cs_dynamicpages.views.query_three_columns_view import IQueryThreeColumnsView
+from cs_dynamicpages.views.query_columns_view import IQueryColumnsView
 from plone import api
 from plone.app.testing import setRoles
 from plone.app.testing import TEST_USER_ID
@@ -19,24 +19,24 @@ def setUp(self):
         api.content.create(self.portal, "Folder", "other-folder")
         api.content.create(self.portal, "Document", "front-page")
 
-    def test_query_three_columns_view_is_registered(self):
+    def test_query_columns_view_is_registered(self):
         view = getMultiAdapter(
             (self.portal["other-folder"], self.portal.REQUEST),
-            name="query-three-columns-view",
+            name="query-columns-view",
         )
-        self.assertTrue(IQueryThreeColumnsView.providedBy(view))
+        self.assertTrue(IQueryColumnsView.providedBy(view))
 
-    def test_query_three_columns_view_not_matching_interface(self):
+    def test_query_columns_view_not_matching_interface(self):
         view_found = True
         try:
             view = getMultiAdapter(
                 (self.portal["front-page"], self.portal.REQUEST),
-                name="query-three-columns-view",
+                name="query-columns-view",
             )
         except ComponentLookupError:
             view_found = False
         else:
-            view_found = IQueryThreeColumnsView.providedBy(view)
+            view_found = IQueryColumnsView.providedBy(view)
         self.assertFalse(view_found)
 
 

src/cs_dynamicpages/views/configure.zcml

@@ -79,13 +79,13 @@
 
   <browser:pages
       for="cs_dynamicpages.content.dynamic_page_row.IDynamicPageRow"
-      class=".query_three_columns_view.QueryThreeColumnsView"
+      class=".query_columns_view.QueryColumnsView"
       permission="zope2.View"
       layer="cs_dynamicpages.interfaces.IBrowserLayer"
       >
     <browser:page
-        name="cs_dynamicpages-query-three-columns-view"
-        template="query_three_columns_view.pt"
+        name="cs_dynamicpages-query-columns-view"
+        template="query_columns_view.pt"
         />
   </browser:pages>
 

…cpages/views/query_three_columns_view.pt …dynamicpages/views/query_columns_view.ptsrc/cs_dynamicpages/views/query_three_columns_view.pt renamed to src/cs_dynamicpages/views/query_columns_view.pt src/cs_dynamicpages/views/query_three_columns_view.pt renamed to src/cs_dynamicpages/views/query_columns_view.pt

@@ -7,7 +7,7 @@
       <tal:define tal:define="
                     element brain/getObject;
                   ">
-        <div class="col-md-4 mb-5">
+        <div class="${context/columns} mb-5">
           <div class="card">
             <tal:image tal:define="
                          image element/image;

…cpages/views/query_three_columns_view.py …dynamicpages/views/query_columns_view.pysrc/cs_dynamicpages/views/query_three_columns_view.py renamed to src/cs_dynamicpages/views/query_columns_view.py src/cs_dynamicpages/views/query_three_columns_view.py renamed to src/cs_dynamicpages/views/query_columns_view.py

@@ -7,15 +7,15 @@
 # from Products.Five.browser.pagetemplatefile import ViewPageTemplateFile
 
 
-class IQueryThreeColumnsView(Interface):
-    """Marker Interface for IQueryThreeColumnsView"""
+class IQueryColumnsView(Interface):
+    """Marker Interface for IQueryColumnsView"""
 
 
-@implementer(IQueryThreeColumnsView)
-class QueryThreeColumnsView(CollectionView, DynamicPageRowView):
+@implementer(IQueryColumnsView)
+class QueryColumnsView(CollectionView, DynamicPageRowView):
     # If you want to define a template here, please remove the template from
     # the configure.zcml registration of this view.
-    # template = ViewPageTemplateFile('query_three_columns_view.pt')
+    # template = ViewPageTemplateFile('query_columns_view.pt')
 
     def __call__(self):
         # Implement your own actions:

src/cs_dynamicpages/vocabularies/row_columns.py

@@ -25,9 +25,9 @@ def __call__(self, context):
         # Just an example list of content for our vocabulary,
         # this can be any static or dynamic data, a catalog result for example.
         items = [
-            VocabItem(u'2', _(u'2')),
-            VocabItem(u'3', _(u'3')),
-            VocabItem(u'4', _(u'4')),
+            VocabItem(u'col-md-6', _(u'2')),
+            VocabItem(u'col-md-4', _(u'3')),
+            VocabItem(u'col-md-3', _(u'4')),
         ]
 
         # Fix context if you are using the vocabulary in DataGridField.