Fixes for infinite looping 500 errors and redundant table addition

Author: geekygirlsarah

web/templates/statistics.html

@@ -189,67 +189,6 @@ <h5 class="mb-0"><i class="fas fa-chart-pie"></i> Category Popularity</h5>
                 </div>
             </div>
         </div>
-        <div class="col-md-6">
-            <div class="card mb-4 shadow-sm">
-                <div class="card-header bg-success text-white">
-                    <h5 class="mb-0"><i class="fas fa-language"></i> Most Popular Languages</h5>
-                </div>
-                <div class="card-body">
-                    {% if popular_languages %}
-                    <table class="table table-hover table-sm">
-                        <thead>
-                            <tr>
-                                <th>Language</th>
-                                <th class="text-end">Occurrences</th>
-                            </tr>
-                        </thead>
-                        <tbody>
-                            {% for lang in popular_languages %}
-                            <tr>
-                                <td>{{ lang.name }}</td>
-                                <td class="text-end">{{ lang.count }}</td>
-                            </tr>
-                            {% endfor %}
-                        </tbody>
-                    </table>
-                    {% else %}
-                    <p class="text-center">No data available yet.</p>
-                    {% endif %}
-                </div>
-            </div>
-        </div>
-    </div>
-
-    <div class="row">
-        <div class="col-12">
-            <div class="card mb-4 shadow-sm">
-                <div class="card-header bg-info text-white">
-                    <h5 class="mb-0"><i class="fas fa-project-diagram"></i> Most Popular Concept Categories</h5>
-                </div>
-                <div class="card-body">
-                    {% if popular_structures %}
-                    <table class="table table-hover table-sm">
-                        <thead>
-                            <tr>
-                                <th>Category</th>
-                                <th class="text-end">Lookups</th>
-                            </tr>
-                        </thead>
-                        <tbody>
-                            {% for struct in popular_structures %}
-                            <tr>
-                                <td>{{ struct.name }}</td>
-                                <td class="text-end">{{ struct.count }}</td>
-                            </tr>
-                            {% endfor %}
-                        </tbody>
-                    </table>
-                    {% else %}
-                    <p class="text-center">No data available yet.</p>
-                    {% endif %}
-                </div>
-            </div>
-        </div>
     </div>
 </div>
 

web/views.py

@@ -33,45 +33,59 @@
 
 
 def store_url_info(request):
-    if 'HTTP_USER_AGENT' in request.META:
-        user_agent = request.META['HTTP_USER_AGENT']
-    else:
-        user_agent = ""
+    try:
+        if 'HTTP_USER_AGENT' in request.META:
+            user_agent = request.META['HTTP_USER_AGENT']
+        else:
+            user_agent = ""
 
-    if 'HTTP_REFERER' in request.META:
-        referer = request.META['HTTP_REFERER']
-    else:
-        referer = ""
+        if 'HTTP_REFERER' in request.META:
+            referer = request.META['HTTP_REFERER']
+        else:
+            referer = ""
 
-    visit = SiteVisit(
-        url=request.get_full_path(),
-        user_agent=user_agent,
-        referer=referer,
-    )
-    visit.save()
-    return visit
+        visit = SiteVisit(
+            url=request.get_full_path(),
+            user_agent=user_agent,
+            referer=referer,
+        )
+        visit.save()
+        return visit
+    except Exception as e:
+        logging.error(f"Failed to store URL info: {e}")
+        return None
 
 
 def store_lookup_info(request, visit, language1, version1, language2, version2, structure):
-    info = LookupData(
-        language1=language1,
-        version1=version1,
-        language2=language2,
-        version2=version2,
-        structure=structure,
-        site_visit=visit
-    )
-    info.save()
+    if not visit:
+        return
+    try:
+        info = LookupData(
+            language1=language1,
+            version1=version1,
+            language2=language2,
+            version2=version2,
+            structure=structure,
+            site_visit=visit
+        )
+        info.save()
+    except Exception as e:
+        logging.error(f"Failed to store lookup info: {e}")
 
 
 def store_missing_info(visit, item_type, item_value, language_context=None):
-    info = MissingLookup(
-        item_type=item_type,
-        item_value=item_value,
-        language_context=language_context,
-        site_visit=visit
-    )
-    info.save()
+    if not visit:
+        return
+    try:
+        info = MissingLookup(
+            item_type=item_type,
+            item_value=item_value,
+            language_context=language_context,
+            site_visit=visit
+        )
+        info.save()
+    except Exception as e:
+        logging.error(f"Failed to store missing info: {e}")
 
 
 @require_http_methods(['GET'])
@@ -496,9 +510,12 @@ def error_handler_500_server_error(request):
     :param request: HttpRequest object
     :return: HttpResponse object with rendered object of the page
     """
-    store_url_info(request)
+    try:
+        store_url_info(request)
+    except Exception:
+        pass
 
-    logging.error(request)
+    logging.error(f"500 error at {request.get_full_path()}")
     response = render(request, 'error500.html')
     return HttpResponseServerError(response)