Adds logic to Repo#update_from_github handle more sittuations (like removeal of the repo and change of properties)

Author: hbontempo-br

app/models/repo.rb

@@ -192,12 +192,26 @@ def self.exists_with_name?(name)
   end
 
   def update_from_github
-    json = fetcher.as_json
-    self.update(
-      language: json.fetch('language', language),
-      description: json.fetch('description', description)&.first(255),
-      stars_count: json.fetch('stargazers_count', stars_count)
-    )
+    if fetcher.not_found?
+      self.update!(removed_from_github: true)
+    elsif fetcher.success?
+      repo_full_name = fetcher_json.fetch('full_name', full_name)
+
+      if repo_full_name != full_name && self.class.exists_with_name?(repo_full_name)
+        # TODO: Add deduplication step
+        return
+      end
+
+      repo_user_name, repo_name = repo_full_name.split("/")
+      self.update!(
+        name: repo_name,
+        user_name: repo_user_name,
+        language: fetcher_json.fetch('language', language),
+        description: fetcher_json.fetch('description', description)&.first(255),
+        full_name: repo_full_name,
+        removed_from_github: false
+      )
+    end
   end
 
   def repo_path

test/jobs/update_repo_info_job_test.rb

@@ -2,8 +2,70 @@
 
 require 'test_helper'
 
+# frozen_string_literal: true
+
+require 'test_helper'
 class UpdateRepoInfoJobTest < ActiveJob::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+  test 'repo deleted or made private' do
+    GithubFetcher::Resource.any_instance.stubs(:status).returns(404)
+    @repo = repos(:node)
+    assert_changes -> {
+      [
+        @repo.reload.removed_from_github,
+      ]
+    } do
+      UpdateRepoInfoJob.perform_now(@repo)
+    end
+    assert @repo.reload.removed_from_github
+  end
+
+  test 'repo with information updated' do
+    GithubFetcher::Resource.any_instance.stubs(:status).returns(200)
+    GithubFetcher::Resource.any_instance.stubs(:as_json).returns(
+      {
+        'full_name' => 'test_owner/test_repo',
+        'language' => 'test_language',
+        'description' => 'test_description'
+      }
+    )
+    @repo = repos(:node)
+    assert_changes -> {
+      [
+        @repo.reload.full_name,
+        @repo.reload.name,
+        @repo.reload.user_name,
+        @repo.reload.language,
+        @repo.reload.description,
+      ]
+    } do
+      UpdateRepoInfoJob.perform_now(@repo)
+    end
+    assert_equal false, @repo.reload.removed_from_github
+    assert_equal 'test_owner/test_repo', @repo.reload.full_name
+    assert_equal 'test_repo', @repo.reload.name
+    assert_equal 'test_owner', @repo.reload.user_name
+    assert_equal 'test_language', @repo.reload.language
+    assert_equal 'test_description', @repo.reload.description
+  end
+
+  test 'repo rename conflict' do
+    GithubFetcher::Resource.any_instance.stubs(:status).returns(200)
+    GithubFetcher::Resource.any_instance.stubs(:as_json).returns(
+      {
+        'full_name' => 'sinatra/sinatra',
+      }
+    )
+    @repo = repos(:node)
+    assert_no_changes -> {
+      [
+        @repo.reload.full_name,
+        @repo.reload.name,
+        @repo.reload.user_name,
+        @repo.reload.language,
+        @repo.reload.description,
+      ]
+    } do
+      UpdateRepoInfoJob.perform_now(@repo)
+    end
+  end
 end