Rename random method

Author: schneems

app/models/user.rb

@@ -103,7 +103,10 @@ def auth_is_valid?
   end
 
   @@max_id = nil
-  def self.random
+
+  # Much faster than order("RANDOM()") but it's
+  # not guaranteed to return results
+  def self.fast_rand
     @@max_id = self.maximum(:id) if @@max_id.nil?
 
     where("id >= ?", Random.new.rand(1..@@max_id))

config/initializers/git_hub_bub.rb

@@ -33,7 +33,7 @@ def call
     @mutex.synchronize do
       return if @keys.any?
 
-      @keys = User.random.where.not(token: nil).limit(5000).pluck(:token)
+      @keys = User.fast_rand.where.not(token: nil).limit(5000).pluck(:token)
 
       if @keys.empty? && User.where.not(token: nil).empty?
         raise "No users with tokens in the database"

test/unit/repo_test.rb

@@ -45,7 +45,7 @@ class RepoTest < ActiveSupport::TestCase
       repo = Repo.create user_name: 'Refinery', name: 'Refinerycms'
       repo.users << users(:jroes)
       repo.users << users(:schneems)
-      repo.subscriber_count == 2
+      repo.subscribers_count == 2
     end
   end