Rubocop

Author: schneems

app/mailers/user_mailer.rb

@@ -75,7 +75,7 @@ def send_triage(user:, assignment:, repo:, create: false)
     mail(to: @user.email, reply_to: "[email protected]", subject: "[CodeTriage] Help triage #{@repo.full_name}")
   end
 
-  def poke_inactive(user:, min_issue_count: , min_subscriber_count: )
+  def poke_inactive(user:, min_issue_count:, min_subscriber_count:)
     return unless set_and_check_user(user)
 
     if @user.favorite_languages.present?
@@ -85,9 +85,9 @@ def poke_inactive(user:, min_issue_count: , min_subscriber_count: )
     end
 
     @repos = @repos
-      .rand
-      .where("issues_count >= ?", min_issue_count)
-      .where("subscribers_count >= ?", min_subscriber_count).first(3)
+             .rand
+             .where("issues_count >= ?", min_issue_count)
+             .where("subscribers_count >= ?", min_subscriber_count).first(3)
     mail(to: @user.email, reply_to: "[email protected]", subject: "CodeTriage misses you")
   end
 

lib/tasks/schedule.rake

@@ -61,15 +61,15 @@ namespace :schedule do
   task poke_inactive: :environment do
     next unless Date.today.tuesday?
 
-
     perc_90_issues_count = ActiveRecord::Base.connection.select_one("SELECT PERCENTILE_CONT(0.90) WITHIN GROUP(ORDER BY issues_count) FROM repos;")["percentile_cont"]
     perc_90_subscriber_count = ActiveRecord::Base.connection.select_one("SELECT PERCENTILE_CONT(0.90) WITHIN GROUP(ORDER BY subscribers_count) FROM repos;")["percentile_cont"]
 
     User.inactive.find_each(batch_size: 100) do |user|
       BackgroundInactiveEmailJob.perform_later(
         user,
         min_issue_count: perc_90_issues_count,
-        min_subscriber_count: perc_90_subscriber_count)
+        min_subscriber_count: perc_90_subscriber_count
+      )
     end
   end
 

test/functional/user_mailer_test.rb

@@ -6,7 +6,11 @@ class UserMailerTest < ActionMailer::TestCase
   test "send_triage works" do
     repo_sub = repo_subscriptions(:schneems_to_triage)
     assignment = issue_assignments(:one)
-    email = UserMailer.send_triage(repo: repo_sub.repo, user: repo_sub.user, assignment: assignment)
+    email = UserMailer.send_triage(
+      repo: repo_sub.repo,
+      user: repo_sub.user,
+      assignment: assignment,
+    )
 
     assert_emails 1 do
       email.deliver_now
@@ -15,7 +19,11 @@ class UserMailerTest < ActionMailer::TestCase
 
   test "poke_inactive works" do
     user = users(:schneems)
-    email = UserMailer.poke_inactive(user: user, repos_by_need_ids: Repo.first(10).map(&:id))
+    email = UserMailer.poke_inactive(
+      user: user,
+      min_issue_count: 0,
+      min_subscriber_count: 0,
+    )
 
     assert_emails 1 do
       email.deliver_now