Define padding scales and default paddings

Make defaults match previously hard-coded paddings for different
appearance options.

REDMINE-21191

Author: tf

entry_types/scrolled/config/locales/de.yml

@@ -1309,6 +1309,28 @@ de:
         add: Neues Element
         unset: Nicht mehr als Hintergrund verwenden
       scales:
+        sectionPaddingTop:
+          none: "-"
+          xxxs: XXXS
+          xxs: XXS
+          xs: XS
+          sm: S
+          md: M
+          lg: L
+          xl: XL
+          xxl: XXL
+          xxxl: XXXL
+        sectionPaddingBottom:
+          none: "-"
+          xxxs: XXXS
+          xxs: XXS
+          xs: XS
+          sm: S
+          md: M
+          lg: L
+          xl: XL
+          xxl: XXL
+          xxxl: XXXL
         contentElementBoxBorderRadius:
           none: Keine
       content_element_text_inline_file_rights_attributes:

entry_types/scrolled/config/locales/en.yml

@@ -1293,6 +1293,28 @@ en:
         add: New element
         unset: No longer use as backdrop
       scales:
+        sectionPaddingTop:
+          none: "-"
+          xxxs: XXXS
+          xxs: XXS
+          xs: XS
+          sm: S
+          md: M
+          lg: L
+          xl: XL
+          xxl: XXL
+          xxxl: XXXL
+        sectionPaddingBottom:
+          none: "-"
+          xxxs: XXXS
+          xxs: XXS
+          xs: XS
+          sm: S
+          md: M
+          lg: L
+          xl: XL
+          xxl: XXL
+          xxxl: XXXL
         contentElementBoxBorderRadius:
           none: None
       content_element_text_inline_file_rights_attributes:

entry_types/scrolled/lib/pageflow_scrolled/plugin.rb

@@ -7,6 +7,46 @@ def configure(config)
       end
 
       config.for_entry_type(PageflowScrolled.entry_type) do |c|
+        padding_scale = {
+          'none' => '0px',
+          'xxxs' => '1.375em',
+          'xxs' => '3em',
+          'xs' => '4.375em',
+          'sm' => '6em',
+          'md' => 'max(7em, 10svh)',
+          'lg' => 'max(8em, 10svh)',
+          'xl' => 'max(9em, 15svh)',
+          'xxl' => 'max(10em, 20svh)',
+          'xxxl' => 'max(11em, 30svh)'
+        }
+
+        c.themes.register_default_options(
+          ThemeOptionsDefaultScale.new(
+            prefix: 'section_padding_top',
+            values: padding_scale
+          )
+        )
+
+        c.themes.register_default_options(
+          ThemeOptionsDefaultScale.new(
+            prefix: 'section_padding_bottom',
+            values: padding_scale
+          )
+        )
+
+        c.themes.register_default_options(
+          properties: {
+            root: {
+              'section_default_padding_top' => '1.375em',
+              'section_default_padding_bottom' => '4.375em'
+            },
+            cards_appearance_section: {
+              'section_default_padding_top' => '3em',
+              'section_default_padding_bottom' => '6em'
+            }
+          }
+        )
+
         c.file_types.register(Pageflow::BuiltInFileType.image)
         c.file_types.register(Pageflow::BuiltInFileType.video)
         c.file_types.register(Pageflow::BuiltInFileType.audio)

entry_types/scrolled/lib/pageflow_scrolled/theme_options_default_scale.rb

@@ -0,0 +1,35 @@
+module PageflowScrolled
+  # Callable that ensures a scale with the given prefix is defined
+  # in theme options. If the theme already defines any properties
+  # with the prefix, the defaults are not added.
+  #
+  # @api private
+  class ThemeOptionsDefaultScale
+    def initialize(prefix:, values:)
+      @prefix = prefix
+      @values = values
+    end
+
+    def call(options)
+      return options if scale_defined?(options)
+
+      options.deep_merge(
+        properties: {
+          root: prefixed_values
+        }
+      )
+    end
+
+    private
+
+    def scale_defined?(options)
+      options.dig(:properties, :root)&.keys&.any? do |key|
+        key.to_s.start_with?("#{@prefix}-")
+      end
+    end
+
+    def prefixed_values
+      @values.transform_keys { |key| "#{@prefix}-#{key}" }
+    end
+  end
+end

entry_types/scrolled/spec/pageflow_scrolled/theme_options_default_scale_spec.rb

@@ -0,0 +1,90 @@
+require 'spec_helper'
+
+module PageflowScrolled
+  RSpec.describe ThemeOptionsDefaultScale do
+    it 'adds scale defaults if no scale properties defined' do
+      transform = ThemeOptionsDefaultScale.new(
+        prefix: 'section_padding_top',
+        values: {'none' => '0', 'sm' => '1em'}
+      )
+
+      result = transform.call({})
+
+      expect(result).to eq(
+        properties: {
+          root: {
+            'section_padding_top-none' => '0',
+            'section_padding_top-sm' => '1em'
+          }
+        }
+      )
+    end
+
+    it 'preserves existing theme options' do
+      transform = ThemeOptionsDefaultScale.new(
+        prefix: 'section_padding_top',
+        values: {'none' => '0', 'sm' => '1em'}
+      )
+
+      result = transform.call(colors: {accent: '#f00'})
+
+      expect(result).to eq(
+        colors: {accent: '#f00'},
+        properties: {
+          root: {
+            'section_padding_top-none' => '0',
+            'section_padding_top-sm' => '1em'
+          }
+        }
+      )
+    end
+
+    it 'does not add defaults if theme defines any scale property' do
+      transform = ThemeOptionsDefaultScale.new(
+        prefix: 'section_padding_top',
+        values: {'none' => '0', 'sm' => '1em', 'md' => '2em'}
+      )
+
+      result = transform.call(
+        properties: {
+          root: {
+            'section_padding_top-lg' => '5em'
+          }
+        }
+      )
+
+      expect(result).to eq(
+        properties: {
+          root: {
+            'section_padding_top-lg' => '5em'
+          }
+        }
+      )
+    end
+
+    it 'adds defaults for one scale even if other scale is defined' do
+      transform = ThemeOptionsDefaultScale.new(
+        prefix: 'section_padding_top',
+        values: {'none' => '0', 'sm' => '1em'}
+      )
+
+      result = transform.call(
+        properties: {
+          root: {
+            'section_padding_bottom-lg' => '5em'
+          }
+        }
+      )
+
+      expect(result).to eq(
+        properties: {
+          root: {
+            'section_padding_bottom-lg' => '5em',
+            'section_padding_top-none' => '0',
+            'section_padding_top-sm' => '1em'
+          }
+        }
+      )
+    end
+  end
+end