Fix eslint setup

Update ignored files and fix a couple of errors.

Author: tf

entry_types/scrolled/package/.eslintignore

@@ -1,3 +1,15 @@
-node_modules
+/src/editor/vendor
+
+/node_modules
+/contentElements
 /editor.js
 /frontend
+/frontend-server.js
+/contentElements-editor.js
+/contentElements-frontend.js
+/contentElements-frontend.css
+/testHelpers.js
+/widgets
+/.storybook/out/
+/.storybook/seed.json
+/.storybook/preview-head.html

entry_types/scrolled/package/.eslintrc.js

@@ -5,6 +5,9 @@ module.exports = {
     "plugin:import/warnings",
     "plugin:storybook/recommended"
   ],
+  "rules": {
+    "no-trailing-spaces": "error"
+  },
   "settings": {
     "import/resolver": {
       "jest": {

entry_types/scrolled/package/package.json

@@ -85,7 +85,7 @@
   },
   "scripts": {
     "test": "jest",
-    "lint": "eslint .",
+    "lint": "eslint",
     "start-storybook": "storybook dev --port 8001",
     "build-storybook": "storybook build -o .storybook/out",
     "snapshot": "storybook build --quiet -o .storybook/out && PERCY_TOKEN=${PERCY_TOKEN:-$PT} percy storybook .storybook/out"

entry_types/scrolled/package/spec/contentElements/externalLinkList/editor/models/ExternalLinkCollection-spec.js

@@ -1,4 +1,3 @@
-import Backbone from 'backbone';
 
 import {
   ExternalLinkCollection

entry_types/scrolled/package/spec/frontend/Atmo-spec.js

@@ -1,4 +1,3 @@
-import _ from 'underscore';
 import {media, PlayerSourceIDMap, MultiPlayer} from 'pageflow/frontend';
 import {Atmo} from 'frontend/Atmo';
 
@@ -11,12 +10,12 @@ describe('Atmo', function() {
     {type: 'audio/m4a', src: 'http://example.com/example.m4a'},
     {type: 'audio/mp3', src: 'http://example.com/example.ogg'}
   ];
-  
+
   let updateAtmo = (config, pool, atmo) => {
     if (config.sources) {
       pool.mapSources(config.atmoAudioFileId, config.sources);
     }
-    
+
     atmo.atmoSourceId = config.atmoAudioFileId;
     atmo.update();
   }
@@ -25,8 +24,8 @@ describe('Atmo', function() {
     it('fades to atmo audio file', function() {
       let {pool, atmo, multiPlayer} = buildAtmo({});
       let multiPlayerSpy = jest.spyOn(multiPlayer, 'fadeTo');
-      
-      media.mute(false);    
+
+      media.mute(false);
       updateAtmo({
         sources: fileSources,
         atmoAudioFileId: 5
@@ -39,27 +38,27 @@ describe('Atmo', function() {
     it('does not fade to audio file if atmo is disabled', function() {
       let {pool, atmo, multiPlayer} = buildAtmo({});
       let multiPlayerSpy = jest.spyOn(multiPlayer, 'fadeTo');
-      
+
       media.mute(false);
       atmo.disable();
       updateAtmo({
         sources: fileSources,
         atmoAudioFileId: 5
       }, pool, atmo);
-      
+
       expect(multiPlayerSpy).not.toHaveBeenCalledWith(5);
     });
 
     it('pauses multiPlayer if backgroundMedia is muted', function() {
       let {pool, atmo, multiPlayer} = buildAtmo({});
       let multiPlayerSpy = jest.spyOn(multiPlayer, 'fadeOutAndPause');
-      
+
       media.mute(true);
       updateAtmo({
         sources: fileSources,
         atmoAudioFileId: 5
       }, pool, atmo);
-      
+
       expect(multiPlayerSpy).toHaveBeenCalled();
     });
 
@@ -78,7 +77,7 @@ describe('Atmo', function() {
     });
 
     it('updates atmo on documment visible state', function() {
-      let {pool, atmo, multiPlayer} = buildAtmo({});
+      let {pool, atmo} = buildAtmo({});
       let atmoSpy = jest.spyOn(atmo, 'update');
 
       updateAtmo({
@@ -106,7 +105,7 @@ describe('Atmo', function() {
       }, pool, atmo);
 
       multiPlayer.trigger('playfailed');
-      
+
       expect(mediaSpy).toHaveBeenCalled();
     });
   });
@@ -122,7 +121,7 @@ describe('Atmo', function() {
       }, pool, atmo);
 
       atmo.pause();
-      
+
       expect(multiPlayerSpy).toHaveBeenCalled();
     });
   });
@@ -140,7 +139,7 @@ describe('Atmo', function() {
 
         media.mute(false);
         atmo.resume();
-        
+
         expect(multiPlayerSpy).toHaveBeenCalled();
       });
 
@@ -156,7 +155,7 @@ describe('Atmo', function() {
         media.mute(false);
         atmo.disable();
         atmo.resume();
-        
+
         expect(multiPlayerSpy).not.toHaveBeenCalled();
       });
 
@@ -171,7 +170,7 @@ describe('Atmo', function() {
 
         media.mute(true);
         atmo.resume();
-        
+
         expect(multiPlayerSpy).not.toHaveBeenCalled();
       });
     });

entry_types/scrolled/package/spec/frontend/features/scrollToSectionMessage-spec.js

@@ -67,7 +67,7 @@ describe('SCROLL_TO_SECTION message', () => {
   });
 
   it('activates excursion of section', async () => {
-    const {fakeSectionBoundingClientRectsByPermaId} = renderEntry({
+    renderEntry({
       seed: {
         storylines: [
           {

entry_types/scrolled/package/spec/frontend/inlineEditing/EditableInlineText/lineBreaks-spec.js

@@ -6,7 +6,7 @@ import {
 
 import {createHyperscript} from 'slate-hyperscript';
 
-export const jsx = createHyperscript({
+const jsx = createHyperscript({
   elements: {
     block: {},
     inline: { inline: true },

entry_types/scrolled/package/spec/frontend/inlineEditing/EditableTable/withFixedColumns-spec.js

@@ -6,7 +6,7 @@ import {
 
 import {createHyperscript} from 'slate-hyperscript';
 
-export const h = createHyperscript({
+const h = createHyperscript({
   elements: {
     row: {type: 'row'},
     label: {type: 'label'},

entry_types/scrolled/package/spec/frontend/inlineEditing/EditableText/getUniformSelectedNode-spec.js

@@ -5,7 +5,7 @@ import {
 
 import {createHyperscript} from 'slate-hyperscript';
 
-export const jsx = createHyperscript({
+const jsx = createHyperscript({
   elements: {
     textBlock: {type: 'textBlock'},
     inlineImage: {type: 'inlineImage'},

entry_types/scrolled/package/spec/frontend/inlineEditing/EditableText/lineBreaks-spec.js

@@ -6,7 +6,7 @@ import {
 
 import {createHyperscript} from 'slate-hyperscript';
 
-export const jsx = createHyperscript({
+const jsx = createHyperscript({
   elements: {
     block: {},
     inline: { inline: true },