Skip to content

Commit aec8e30

Browse files
authored
Merge pull request #2232 from tf/custom-content-margin
Let themes change content margin
2 parents 657bc1b + 99eddf5 commit aec8e30

File tree

3 files changed

+32
-8
lines changed

3 files changed

+32
-8
lines changed

entry_types/scrolled/package/src/frontend/__stories__/appearance-stories.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,25 @@ appearanceOptions.forEach(appearance => {
141141
includeWidths: true})}>
142142
<Entry />
143143
</RootProviders>
144+
)
145+
.add(
146+
'Custom Margin - Custom content margin fraction',
147+
() =>
148+
<RootProviders seed={exampleSeed(appearance, {positionedElementTypeName: 'customMarginExample',
149+
includeWidths: true})}>
150+
<div style={{'--theme-content-margin-fraction': '0.04'}}>
151+
<Entry />
152+
</div>
153+
</RootProviders>
154+
).add(
155+
'Custom Margin - Custom content margin',
156+
() =>
157+
<RootProviders seed={exampleSeed(appearance, {positionedElementTypeName: 'customMarginExample',
158+
includeWidths: true})}>
159+
<div style={{'--theme-content-margin': '3rem'}}>
160+
<Entry />
161+
</div>
162+
</RootProviders>
144163
);
145164
});
146165

entry_types/scrolled/package/src/frontend/layouts/Center.module.css

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
.outer {
2-
padding-left: 8%;
3-
padding-right: 8%;
2+
--content-margin-fraction: var(--theme-content-margin-fraction, 0.08);
3+
--content-margin: var(--theme-content-margin,
4+
calc(var(--content-margin-fraction) * 100%));
5+
padding-left: var(--content-margin);
6+
padding-right: var(--content-margin);
47
margin-left: auto;
58
margin-right: auto;
69
max-width: var(--section-max-width, none);
@@ -15,7 +18,6 @@
1518
}
1619

1720
.item {
18-
--content-margin: 8%;
1921
--content-max-width: var(--centered-inline-content-max-width, 700px);
2022
margin-left: auto;
2123
margin-right: auto;

entry_types/scrolled/package/src/frontend/layouts/TwoColumn.module.css

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
}
33

44
.group {
5-
--content-margin-fraction: 0.08;
6-
--content-margin: calc(var(--content-margin-fraction) * 100%);
5+
--content-margin-fraction: var(--theme-content-margin-fraction, 0.08);
6+
--content-margin: var(--theme-content-margin, calc(var(--content-margin-fraction) * 100%));
77
padding-left: var(--content-margin);
88
padding-right: var(--content-margin);
99
margin-left: auto;
@@ -36,6 +36,7 @@
3636

3737
.inline.width-full {
3838
--content-margin-fraction: 0;
39+
--content-margin: 0;
3940
--content-max-width: none;
4041
}
4142

@@ -71,9 +72,11 @@
7172
<=> group-width = box-width / (1 - 2 * content-margin-factor)
7273
*/
7374
--f: calc(1 / (1 - 2 * var(--content-margin-fraction)));
74-
margin-left: calc(-100% * var(--content-margin-fraction) * var(--f));
75-
margin-right: calc(-100% * var(--content-margin-fraction) * var(--f));
76-
max-width: calc(var(--content-margin) * var(--f) * 2 + var(--content-max-width));
75+
--margin-to-undo: var(--theme-content-margin,
76+
calc(100% * var(--content-margin-fraction) * var(--f)));
77+
margin-left: calc(-1 * var(--margin-to-undo));
78+
margin-right: calc(-1 * var(--margin-to-undo));
79+
max-width: calc(var(--margin-to-undo) * 2 + var(--content-max-width));
7780
}
7881

7982
.right .inline {

0 commit comments

Comments
 (0)