Improve action menu labels for text blocks

Show "Delete selection" and "Duplicate selection" labels when
text block handles the action itself (operating on selected
paragraphs rather than the whole element). Also make section
duplicate label more explicit.

REDMINE-21205

Author: tf

entry_types/scrolled/config/locales/de.yml

@@ -1157,8 +1157,10 @@ de:
       destroy_content_element_menu_item:
         confirm_destroy: Element wirklich löschen?
         destroy: Element löschen
+        selection_label: Auswahl löschen
       duplicate_content_element_menu_item:
         label: Element duplizieren
+        selection_label: Auswahl duplizieren
       destroy_section_menu_item:
         confirm_destroy: Abschnitt inklusive aller Elemente wirklich löschen?
         destroy: Abschnitt löschen
@@ -1292,7 +1294,7 @@ de:
           scrollOver: Überlagern
       section_menu_items:
         copy_permalink: Permalink kopieren
-        duplicate: Duplizieren
+        duplicate: Abschnitt duplizieren
         hide: Außerhalb des Editors ausblenden
         insert_section_above: Abschnitt oberhalb einfügen
         insert_section_below: Abschnitt unterhalb einfügen

entry_types/scrolled/config/locales/en.yml

@@ -1141,8 +1141,10 @@ en:
       destroy_content_element_menu_item:
         confirm_destroy: Really delete this element?
         destroy: Delete element
+        selection_label: Delete selection
       duplicate_content_element_menu_item:
         label: Duplicate element
+        selection_label: Duplicate selection
       destroy_section_menu_item:
         confirm_destroy: Really delete this section including all its elements?
         destroy: Delete section
@@ -1276,7 +1278,7 @@ en:
           scrollOver: Scroll over
       section_menu_items:
         copy_permalink: Copy permalink
-        duplicate: Duplicate
+        duplicate: Duplicate section
         hide: Hide outside of the editor
         insert_section_above: Insert section above
         insert_section_below: Insert section below

entry_types/scrolled/package/spec/editor/models/contentElementMenuItems-spec.js

@@ -7,7 +7,8 @@ import {factories, normalizeSeed} from 'support';
 describe('ContentElementMenuItems', () => {
   describe('DuplicateContentElementMenuItem', () => {
     useFakeTranslations({
-      'pageflow_scrolled.editor.duplicate_content_element_menu_item.label': 'Duplicate element'
+      'pageflow_scrolled.editor.duplicate_content_element_menu_item.label': 'Duplicate element',
+      'pageflow_scrolled.editor.duplicate_content_element_menu_item.selection_label': 'Duplicate selection'
     });
 
     it('has Duplicate element label', () => {
@@ -18,6 +19,7 @@ describe('ContentElementMenuItems', () => {
         })
       });
       const contentElement = entry.contentElements.get(1);
+      editor.contentElementTypes.register('textBlock', {});
 
       const menuItem = new DuplicateContentElementMenuItem({}, {
         contentElement,
@@ -28,6 +30,25 @@ describe('ContentElementMenuItems', () => {
       expect(menuItem.get('label')).toBe('Duplicate element');
     });
 
+    it('has Duplicate selection label when handleDuplicate is defined', () => {
+      const editor = factories.editorApi();
+      const entry = factories.entry(ScrolledEntry, {}, {
+        entryTypeSeed: normalizeSeed({
+          contentElements: [{id: 1, typeName: 'textBlock'}]
+        })
+      });
+      const contentElement = entry.contentElements.get(1);
+      editor.contentElementTypes.register('textBlock', {handleDuplicate() {}});
+
+      const menuItem = new DuplicateContentElementMenuItem({}, {
+        contentElement,
+        entry,
+        editor
+      });
+
+      expect(menuItem.get('label')).toBe('Duplicate selection');
+    });
+
     it('calls duplicateContentElement on entry when selected', () => {
       const editor = factories.editorApi();
       const entry = factories.entry(ScrolledEntry, {}, {
@@ -78,6 +99,7 @@ describe('ContentElementMenuItems', () => {
   describe('DestroyContentElementMenuItem', () => {
     useFakeTranslations({
       'pageflow_scrolled.editor.destroy_content_element_menu_item.destroy': 'Delete element',
+      'pageflow_scrolled.editor.destroy_content_element_menu_item.selection_label': 'Delete selection',
       'pageflow_scrolled.editor.destroy_content_element_menu_item.confirm_destroy': 'Really delete this element?'
     });
 
@@ -89,6 +111,7 @@ describe('ContentElementMenuItems', () => {
         })
       });
       const contentElement = entry.contentElements.get(1);
+      editor.contentElementTypes.register('textBlock', {});
 
       const menuItem = new DestroyContentElementMenuItem({}, {
         contentElement,
@@ -99,6 +122,25 @@ describe('ContentElementMenuItems', () => {
       expect(menuItem.get('label')).toBe('Delete element');
     });
 
+    it('has Delete selection label when handleDestroy is defined', () => {
+      const editor = factories.editorApi();
+      const entry = factories.entry(ScrolledEntry, {}, {
+        entryTypeSeed: normalizeSeed({
+          contentElements: [{id: 1, typeName: 'textBlock'}]
+        })
+      });
+      const contentElement = entry.contentElements.get(1);
+      editor.contentElementTypes.register('textBlock', {handleDestroy() {}});
+
+      const menuItem = new DestroyContentElementMenuItem({}, {
+        contentElement,
+        entry,
+        editor
+      });
+
+      expect(menuItem.get('label')).toBe('Delete selection');
+    });
+
     it('calls deleteContentElement on entry when confirmed', () => {
       const editor = factories.editorApi();
       const entry = factories.entry(ScrolledEntry, {}, {

entry_types/scrolled/package/src/editor/models/contentElementMenuItems.js

@@ -7,7 +7,15 @@ export const DuplicateContentElementMenuItem = Backbone.Model.extend({
     this.contentElement = options.contentElement;
     this.entry = options.entry;
     this.editor = options.editor;
-    this.set('label', I18n.t('pageflow_scrolled.editor.duplicate_content_element_menu_item.label'));
+
+    const contentElementType =
+      this.editor.contentElementTypes.findByTypeName(this.contentElement.get('typeName'));
+
+    this.set('label', I18n.t(
+      contentElementType.handleDuplicate ?
+        'pageflow_scrolled.editor.duplicate_content_element_menu_item.selection_label' :
+        'pageflow_scrolled.editor.duplicate_content_element_menu_item.label'
+    ));
   },
 
   selected() {
@@ -32,6 +40,15 @@ export const DestroyContentElementMenuItem = DestroyMenuItem.extend({
     this.editor = options.editor;
 
     DestroyMenuItem.prototype.initialize.call(this, attributes, options);
+
+    const contentElementType =
+      this.editor.contentElementTypes.findByTypeName(this.contentElement.get('typeName'));
+
+    if (contentElementType.handleDestroy) {
+      this.set('label', I18n.t(
+        'pageflow_scrolled.editor.destroy_content_element_menu_item.selection_label'
+      ));
+    }
   },
 
   destroyModel() {