File tree Expand file tree Collapse file tree 3 files changed +8
-8
lines changed
Expand file tree Collapse file tree 3 files changed +8
-8
lines changed Original file line number Diff line number Diff line change 1414- ` Fix ` - Fix the memory leak issue in ` Shortcuts ` class
1515- ` Fix ` - Fix when / overides selected text outside of the editor
1616- ` DX ` - Tools submodules removed from the repository
17+ - ` Improvement ` - Shift + Down/Up will allow to select next/previous line instead of Inline Toolbar flipping
18+
1719
1820### 2.30.7
1921
Original file line number Diff line number Diff line change @@ -199,7 +199,7 @@ export default class Flipper {
199199 *
200200 * @param event - keydown event
201201 */
202- private onKeyDown = ( event ) : void => {
202+ private onKeyDown = ( event : KeyboardEvent ) : void => {
203203 const isReady = this . isEventReadyForHandling ( event ) ;
204204
205205 if ( ! isReady ) {
Original file line number Diff line number Diff line change @@ -102,7 +102,7 @@ describe('Flipper', () => {
102102 expect ( SomePlugin . pluginInternalKeydownHandler ) . to . have . not . been . called ;
103103 } ) ;
104104
105- it . only ( 'should not flip when shift key is pressed' , ( ) => {
105+ it ( 'should not flip when shift key is pressed' , ( ) => {
106106 cy . createEditor ( {
107107 data : {
108108 blocks : [
@@ -121,13 +121,11 @@ describe('Flipper', () => {
121121 . get ( '.ce-paragraph' )
122122 . as ( 'paragraph' )
123123 . selectTextByOffset ( [ 0 , 10 ] )
124- . wait ( 200 )
125- . type ( '{shift}{downArrow}' ) ;
124+ . wait ( 200 ) ;
126125
127- // .trigger('keydown', { keyCode: ARROW_DOWN_KEY_CODE,
128- // shiftKey: true })
129- // .trigger('keydown', { keyCode: ARROW_DOWN_KEY_CODE,
130- // shiftKey: true });
126+ cy . get ( '@paragraph' )
127+ . trigger ( 'keydown' , { keyCode : ARROW_DOWN_KEY_CODE ,
128+ shiftKey : true } ) ;
131129
132130 // eslint-disable-next-line cypress/require-data-selectors
133131 cy . get ( '[data-cy="inline-toolbar"]' )
You can’t perform that action at this time.
0 commit comments