refactor(project): update rateLimitSettings handling to allow null for removal and clean up type definitions

Author: Dobrunia

src/resolvers/project.js

@@ -189,7 +189,7 @@ module.exports = {
      *
      * @param {ResolverObj} _obj
      * @param {string} id - project id
-     * @param {Object} rateLimitSettings - rate limit settings
+     * @param {Object | null} rateLimitSettings - rate limit settings (null to remove)
      * @param {UserInContext} user - current authorized user {@see ../index.js}
      * @param {ContextFactories} factories - factories for working with models
      *
@@ -208,41 +208,13 @@ module.exports = {
 
       try {
         return project.updateProject({
-          rateLimitSettings,
+          rateLimitSettings: rateLimitSettings || null,
         });
       } catch (err) {
         throw new ApolloError('Something went wrong');
       }
     },
 
-    /**
-     * Remove project rate limits settings
-     *
-     * @param {ResolverObj} _obj
-     * @param {string} id - project id
-     * @param {UserInContext} user - current authorized user {@see ../index.js}
-     * @param {ContextFactories} factories - factories for working with models
-     *
-     * @returns {Project}
-     */
-    async removeProjectRateLimits(_obj, { id }, { user, factories }) {
-      const project = await factories.projectsFactory.findById(id);
-
-      if (!project) {
-        throw new ApolloError('There is no project with that id');
-      }
-
-      if (project.workspaceId.toString() === '6213b6a01e6281087467cc7a') {
-        throw new ApolloError('Unable to update demo project');
-      }
-
-      try {
-        return project.updateProject(null, { rateLimitSettings: '' });
-      } catch (err) {
-        throw new ApolloError('Something went wrong');
-      }
-    },
-
     /**
      * Generates new project integration token by id
      *

src/typeDefs/project.ts

@@ -356,19 +356,9 @@ extend type Mutation {
     id: ID!
 
     """
-    Rate limits configuration
-    """
-    rateLimitSettings: RateLimitSettingsInput!
-  ): Project! @requireAdmin
-
-  """
-  Remove project rate limits settings
-  """
-  removeProjectRateLimits(
-    """
-    What project to update
+    Rate limits configuration. Pass null to remove rate limits.
     """
-    id: ID!
+    rateLimitSettings: RateLimitSettingsInput
   ): Project! @requireAdmin
 
   """