Skip to content

Commit 1551190

Browse files
committed
Merge branch 'master' into fix/infinite-cycle
2 parents 7828d79 + 5ef99c4 commit 1551190

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@hawk.so/javascript",
33
"type": "commonjs",
4-
"version": "3.2.6",
4+
"version": "3.2.8",
55
"description": "JavaScript errors tracking for Hawk.so",
66
"files": [
77
"dist"

src/catcher.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ export default class Catcher {
120120
this.user = settings.user || Catcher.getGeneratedUser();
121121
this.context = settings.context || undefined;
122122
this.beforeSend = settings.beforeSend;
123-
this.disableVueErrorHandler = settings.disableVueErrorHandler ?? false;
124-
this.consoleTracking = settings.consoleTracking ?? true;
123+
this.disableVueErrorHandler = settings.disableVueErrorHandler !== null && settings.disableVueErrorHandler !== undefined ? settings.disableVueErrorHandler : false;
124+
this.consoleTracking = settings.consoleTracking !== null && settings.consoleTracking !== undefined ? settings.consoleTracking : true;
125125

126126
if (!this.token) {
127127
log(
@@ -555,10 +555,12 @@ export default class Catcher {
555555
return;
556556
}
557557

558+
const stack = error.stack !== null && error.stack !== undefined ? error.stack : '';
559+
558560
return {
559561
name: error.name,
560562
message: error.message,
561-
stack: error.stack ?? '',
563+
stack,
562564
};
563565
}
564566

src/modules/stackParser.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,12 @@ export default class StackParser {
2424

2525
return Promise.all(stackParsed.map(async (frame) => {
2626
const sourceCode = await this.extractSourceCode(frame);
27-
27+
const file = frame.fileName !== null && frame.fileName !== undefined ? frame.fileName : '';
28+
const line = frame.lineNumber !== null && frame.lineNumber !== undefined ? frame.lineNumber : 0;
29+
2830
return {
29-
file: frame.fileName ?? '',
30-
line: frame.lineNumber ?? 0,
31+
file,
32+
line,
3133
column: frame.columnNumber,
3234
sourceCode: sourceCode !== null ? sourceCode : undefined,
3335
function: frame.functionName,

src/types/hawk-initial-settings.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,11 @@ export interface HawkInitialSettings {
6363
disableGlobalErrorsHandling?: boolean;
6464

6565
/**
66-
* This Method allows you to filter any data you don't want sending to Hawk
66+
* This Method allows you to filter any data you don't want sending to Hawk.
67+
*
68+
* Return `false` to prevent the event from being sent to Hawk.
6769
*/
68-
beforeSend?(event: HawkJavaScriptEvent): HawkJavaScriptEvent;
70+
beforeSend?(event: HawkJavaScriptEvent): HawkJavaScriptEvent | false;
6971

7072
/**
7173
* Disable Vue.js error handler

0 commit comments

Comments
 (0)