Skip to content

Commit 6cb4c76

Browse files
committed
fix notifier test suites
1 parent 470bc93 commit 6cb4c76

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

workers/notifier/tests/worker.test.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,19 +199,19 @@ describe('NotifierWorker', () => {
199199
describe('handling', () => {
200200
it('should not send task to sender workers if event is not new and repetitions today not equal to threshold', async () => {
201201
const worker = new NotifierWorker();
202-
202+
203203
await worker.start();
204204

205205
const message = { ...messageMock };
206206
const event = { ...message.event };
207207
event.isNew = false;
208208

209209
worker.redis.getEventRepetitionsFromDigest = jest.fn(async (_projectId, _groupHash) => {
210-
return Promise<1>;
210+
return Promise.resolve(1);
211211
});
212212

213213
worker.redis.getProjectNotificationThreshold = jest.fn(async (_projectId) => {
214-
return Promise<10>;
214+
return Promise.resolve(10);
215215
});
216216

217217
worker.sendToSenderWorker = jest.fn();
@@ -225,7 +225,7 @@ describe('NotifierWorker', () => {
225225
expect(worker.sendToSenderWorker).not.toBeCalled();
226226

227227
worker.redis.getEventRepetitionsFromDigest = jest.fn(async (_projectId, _groupHash) => {
228-
return Promise<100>;
228+
return Promise.resolve(100);
229229
});
230230

231231
worker.handle(message);
@@ -268,11 +268,11 @@ describe('NotifierWorker', () => {
268268
event.isNew = false;
269269

270270
worker.redis.getEventRepetitionsFromDigest = jest.fn(async (_projectId, _groupHash) => {
271-
return Promise<10>;
271+
return Promise.resolve(10);
272272
});
273273

274274
worker.redis.getProjectNotificationThreshold = jest.fn(async (_projectId) => {
275-
return Promise<10>;
275+
return Promise.resolve(10);
276276
});
277277

278278
worker.sendToSenderWorker = jest.fn();
@@ -284,7 +284,7 @@ describe('NotifierWorker', () => {
284284
await worker.finish();
285285
});
286286

287-
it('should not call events database for threshold calculation if threshold set in redis', async () => {
287+
it('should not call events database for threshold calculation if threshold stored in redis', async () => {
288288
const worker = new NotifierWorker();
289289

290290
await worker.start();
@@ -293,11 +293,11 @@ describe('NotifierWorker', () => {
293293
* Mock of the function that returns
294294
*/
295295
worker.redis.getEventRepetitionsFromDigest = jest.fn(async (_projectId, _groupHash) => {
296-
return Promise<1>;
296+
return Promise.resolve(1);
297297
});
298298

299299
worker.redis.getProjectNotificationThreshold(async (_projectId) => {
300-
return Promise<1>;
300+
return Promise.resolve(1);
301301
})
302302

303303
worker.eventsDb.getConnection = jest.fn();
@@ -320,7 +320,7 @@ describe('NotifierWorker', () => {
320320
await worker.start();
321321

322322
worker.redis.getProjectNotificationThreshold = jest.fn(async (_projectId, _groupHash) => {
323-
return Promise<null>;
323+
return Promise.resolve(null);
324324
});
325325

326326
worker.eventsDb.getConnection = jest.fn();

0 commit comments

Comments
 (0)