bug fix

Author: Prerak Singh

pydatastructs/graphs/_backend/cpp/AdjacencyListLLVM.hpp

@@ -69,26 +69,34 @@ static PyObject* initialize_llvm_backend(PyObject* self, PyObject* args) {
         return nullptr;
     }
 
-    llvm_graph_init = (GraphInitFunc)PyLong_AsVoidPtr(init_ptr);
-    llvm_add_vertex = (AddVertexFunc)PyLong_AsVoidPtr(add_vertex_ptr);
-    llvm_add_edge = (AddEdgeFunc)PyLong_AsVoidPtr(add_edge_ptr);
-    llvm_is_adjacent = (IsAdjacentFunc)PyLong_AsVoidPtr(is_adjacent_ptr);
-    llvm_remove_vertex = (RemoveVertexFunc)PyLong_AsVoidPtr(remove_vertex_ptr);
-    llvm_remove_edge = (RemoveEdgeFunc)PyLong_AsVoidPtr(remove_edge_ptr);
-    llvm_graph_cleanup = (GraphCleanupFunc)PyLong_AsVoidPtr(cleanup_ptr);
+    void* raw_init = PyLong_AsVoidPtr(init_ptr);
+    void* raw_add_vertex = PyLong_AsVoidPtr(add_vertex_ptr);
+    void* raw_add_edge = PyLong_AsVoidPtr(add_edge_ptr);
+    void* raw_is_adjacent = PyLong_AsVoidPtr(is_adjacent_ptr);
+    void* raw_remove_vertex = PyLong_AsVoidPtr(remove_vertex_ptr);
+    void* raw_remove_edge = PyLong_AsVoidPtr(remove_edge_ptr);
+    void* raw_cleanup = PyLong_AsVoidPtr(cleanup_ptr);
 
     if (PyErr_Occurred()) {
         PyErr_SetString(PyExc_ValueError, "Failed to convert function pointers");
         return nullptr;
     }
 
-    if (!llvm_graph_init || !llvm_add_vertex || !llvm_add_edge ||
-        !llvm_is_adjacent || !llvm_remove_vertex || !llvm_remove_edge ||
-        !llvm_graph_cleanup) {
+    if (!raw_init || !raw_add_vertex || !raw_add_edge ||
+        !raw_is_adjacent || !raw_remove_vertex || !raw_remove_edge ||
+        !raw_cleanup) {
         PyErr_SetString(PyExc_ValueError, "One or more function pointers are null");
         return nullptr;
     }
 
+    llvm_graph_init = (GraphInitFunc)raw_init;
+    llvm_add_vertex = (AddVertexFunc)raw_add_vertex;
+    llvm_add_edge = (AddEdgeFunc)raw_add_edge;
+    llvm_is_adjacent = (IsAdjacentFunc)raw_is_adjacent;
+    llvm_remove_vertex = (RemoveVertexFunc)raw_remove_vertex;
+    llvm_remove_edge = (RemoveEdgeFunc)raw_remove_edge;
+    llvm_graph_cleanup = (GraphCleanupFunc)raw_cleanup;
+
     llvm_backend_initialized = true;
 
     Py_RETURN_NONE;

pydatastructs/graphs/_backend/cpp/llvm_adjacency_list.py

@@ -23,16 +23,42 @@ def __init__(self):
         self.char_ptr = self.int8_type.as_pointer()
         self.void_ptr = self.int8_type.as_pointer()
 
+        triple = self._get_target_triple()
         target = llvm.Target.from_default_triple()
         self.target_machine = target.create_target_machine()
         self.target_data = self.target_machine.target_data
+        self.module.triple = triple
+        self.module.data_layout = str(self.target_data)
 
         self._create_structures()
 
         self._create_function_declarations()
 
         self._create_graph_functions()
 
+    def _get_target_triple(self):
+        import platform
+        system = platform.system().lower()
+        machine = platform.machine().lower()
+
+        if system == "darwin":  # macOS
+            if machine in ["arm64", "aarch64"]:
+                return "arm64-apple-darwin"
+            else:  # x86_64
+                return "x86_64-apple-darwin"
+        elif system == "linux":
+            if machine in ["arm64", "aarch64"]:
+                return "aarch64-unknown-linux-gnu"
+            else:  # x86_64
+                return "x86_64-unknown-linux-gnu"
+        elif system == "windows":
+            if machine in ["arm64", "aarch64"]:
+                return "aarch64-pc-windows-msvc"
+            else:
+                return "x86_64-pc-windows-msvc"
+        else:
+            return llvm.get_default_triple()
+
     def _create_structures(self):
 
         self.node_type = ir.LiteralStructType([
@@ -42,20 +68,20 @@ def _create_structures(self):
             self.void_ptr,
             self.int_type,
             self.int_type
-        ], packed=True)
+        ])
 
         self.edge_type = ir.LiteralStructType([
             self.node_type.as_pointer(),
             self.node_type.as_pointer(),
             self.double_type
-        ], packed=True)
+        ])
 
         self.hash_entry_type = ir.LiteralStructType([
             self.char_ptr,
             self.int_type,
             self.void_ptr,
             self.void_ptr
-        ], packed=True)
+        ])
 
         self.graph_type = ir.LiteralStructType([
             self.node_type.as_pointer().as_pointer(),
@@ -64,7 +90,7 @@ def _create_structures(self):
             self.void_ptr,
             self.void_ptr,
             self.int_type
-        ], packed=True)
+        ])
 
     def _get_target_data(self):
         return self.target_machine.target_data

pydatastructs/utils/_extensions.py

@@ -36,11 +36,11 @@
     Extension(
         nodes,
         sources=nodes_sources,
-        extra_compile_args=["-std=c++17"],
+        extra_compile_args=extra_compile_args,
     ),
     Extension(
         graph_utils,
         sources=graph_utils_sources,
-        extra_compile_args=["-std=c++17"],
+        extra_compile_args=extra_compile_args,
     ),
 ]