From b0a1381ef99bf0a6ff6fcaa8b9e0492ab38a94c6 Mon Sep 17 00:00:00 2001 From: czgdp1807 Date: Sun, 27 Jul 2025 17:32:52 +0530 Subject: [PATCH 1/7] CI: use clang on windows --- .github/workflows/ci.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 27343bb9..694bc81e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -190,9 +190,15 @@ jobs: python -m pip install -r requirements.txt python -m pip install -r docs/requirements.txt + - name: Install clang + run: | + choco install llvm -y + - name: Build package env: - CL: "/std:c++17" + CC: clang-cl + CXX: clang-cl + CXXFLAGS: "-std=c++17" run: | python scripts/build/install.py From 0e248acd8c63a6072ad296c19d44d6dbaab57b8c Mon Sep 17 00:00:00 2001 From: czgdp1807 Date: Sun, 27 Jul 2025 17:43:36 +0530 Subject: [PATCH 2/7] Use clang for Windows builds --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 694bc81e..2c577d35 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -193,12 +193,13 @@ jobs: - name: Install clang run: | choco install llvm -y + echo "C:\\Program Files\\LLVM\\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append - name: Build package env: CC: clang-cl CXX: clang-cl - CXXFLAGS: "-std=c++17" + CL: "/std:c++17" run: | python scripts/build/install.py From ea5c199cae2042e8bfd9b6aad02a03d026b9edcd Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Sun, 27 Jul 2025 18:05:55 +0530 Subject: [PATCH 3/7] fix --- .github/workflows/ci.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2c577d35..8e58744e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -192,16 +192,11 @@ jobs: - name: Install clang run: | - choco install llvm -y - echo "C:\\Program Files\\LLVM\\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + choco install llvm -y --force - name: Build package - env: - CC: clang-cl - CXX: clang-cl - CL: "/std:c++17" run: | - python scripts/build/install.py + CC="clang-cl" CXX="clang-cl" python scripts/build/install.py - name: Run tests run: | From 2fd6044973a6de7a04ba93031db7b3433cefacfb Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Sun, 27 Jul 2025 18:12:45 +0530 Subject: [PATCH 4/7] use set --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8e58744e..c817992f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -196,7 +196,9 @@ jobs: - name: Build package run: | - CC="clang-cl" CXX="clang-cl" python scripts/build/install.py + set CC=clang-cl + set CXX=clang-cl + python scripts/build/install.py - name: Run tests run: | From 10ba5b9e74f200642a4e8d07eadeb7701ad4d4b9 Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Sun, 27 Jul 2025 18:22:40 +0530 Subject: [PATCH 5/7] done --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c817992f..4d076feb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -193,6 +193,7 @@ jobs: - name: Install clang run: | choco install llvm -y --force + clang-cl --version - name: Build package run: | From f194b4893d00982b990add40b33ccc5893782db7 Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Sun, 27 Jul 2025 18:28:19 +0530 Subject: [PATCH 6/7] run-cmd --- .github/workflows/ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4d076feb..1724a05c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -199,7 +199,11 @@ jobs: run: | set CC=clang-cl set CXX=clang-cl - python scripts/build/install.py + python scripts/build/add_dummy_submodules.py + python setup.py build_ext --inplace + python -m pip install . + python scripts/build/delete_dummy_submodules.py + python -m pip install . --force-reinstall - name: Run tests run: | From b113f69e743827eac86fc39a54c990316aada452 Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Sun, 27 Jul 2025 18:33:57 +0530 Subject: [PATCH 7/7] change shell --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1724a05c..b23cf953 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -196,6 +196,7 @@ jobs: clang-cl --version - name: Build package + shell: cmd /C call {0} run: | set CC=clang-cl set CXX=clang-cl