Merge branch '0valt/seeds' into temporary-branch-for-testing-ci-failures

Author: Oaphi

app/controllers/post_types_controller.rb

@@ -55,8 +55,9 @@ def post_type_params
   end
 
   def clear_cache!
+    # FIXME: this is likely not clearing cache for rep changes
     Rails.cache.delete 'network/post_types/rep_changes'
-    Rails.cache.delete 'network/post_types/post_type_ids'
+    PostType.clear_ids_cache
     current_community = RequestContext.community
     Community.all.each do |c|
       RequestContext.community = c

app/helpers/seeds_helper.rb

@@ -1,9 +1,37 @@
 module SeedsHelper
-  def update_from_seeds(type, unique_key, value_attribute)
-    data = YAML.load_file(Rails.root.join("db/seeds/#{type}.yml"))
-    cls = type.to_s.singularize.classify.constantize
-    data.each do |seed|
-      cls.unscoped.where(unique_key => seed[unique_key.to_s]).update(value_attribute => seed[value_attribute.to_s])
+  # Gets the list of seed file paths
+  # @param seed_name [String, nil] optional specific seed name to run
+  # @return [Array<String>]
+  def self.files(seed_name)
+    find_glob = if seed_name.present?
+                  "db/seeds/**/#{seed_name.underscore}.yml"
+                else
+                  'db/seeds/**/*.yml'
+                end
+
+    # Get all seed files and determine their model types
+    Dir.glob(Rails.root.join(find_glob))
+  end
+
+  # Parses model classes from the list of file paths
+  # @param files [Array<String>] list of seed file paths
+  # @return [Array<Class>]
+  def self.types(files)
+    files.map do |f|
+      basename = Pathname.new(f).relative_path_from(Pathname.new(Rails.root.join('db/seeds'))).to_s
+      basename.gsub('.yml', '').singularize.classify.constantize
     end
   end
+
+  # Prioritizes models such that dependent ones are created after the specified ones
+  # @param types [Array<Class>] list of model classes
+  # @param files [Array<String>] list of seed file paths
+  # @return [Hash<String, Class>]
+  def self.prioritize(types, files)
+    priority = [PostType, CloseReason, License, TagSet, PostHistoryType, User, Ability, CommunityUser, Filter]
+
+    files.zip(types).to_h.sort do |a, b|
+      (priority.index(a.second) || 999) <=> (priority.index(b.second) || 999)
+    end.to_h
+  end
 end

app/models/post_type.rb

@@ -24,6 +24,10 @@ def system?
     ['HelpDoc', 'PolicyDoc'].include?(name)
   end
 
+  def self.clear_ids_cache
+    Rails.cache.delete 'network/post_types/post_type_ids', include_community: false
+  end
+
   def self.mapping
     Rails.cache.fetch 'network/post_types/post_type_ids', include_community: false do
       PostType.all.to_h { |pt| [pt.name, pt.id] }

db/seeds.rb

@@ -2,24 +2,9 @@
 
 Rails.application.eager_load!
 
-if ENV['SEEDS'].present?
-  find_glob = "db/seeds/**/#{ENV['SEEDS'].underscore}.yml"
-else
-  find_glob = 'db/seeds/**/*.yml'
-end
-
-# Get all seed files and determine their model types
-files = Dir.glob(Rails.root.join(find_glob))
-types = files.map do |f|
-  basename = Pathname.new(f).relative_path_from(Pathname.new(Rails.root.join('db/seeds'))).to_s
-  basename.gsub('.yml', '').singularize.classify.constantize
-end
-
-# Prioritize the following models (in this order) such that models depending on them get created after
-priority = [PostType, CloseReason, License, TagSet, PostHistoryType, User, Ability, CommunityUser, Filter]
-sorted = files.zip(types).to_h.sort do |a, b|
-  (priority.index(a.second) || 999) <=> (priority.index(b.second) || 999)
-end.to_h
+files = SeedsHelper.files(ENV['SEEDS'])
+types = SeedsHelper.types(files)
+sorted = SeedsHelper.prioritize(types, files)
 
 def expand_communities(type, seed)
   if type.column_names.include?('community_id') && !seed.include?('community_id')
@@ -61,6 +46,12 @@ def create_objects(type, seed)
   skipped = objs.select { |o| o.errors.any? }.size
   created = objs.select { |o| !o.errors.any? }.size
 
+  # Post type cache must be manually cleared \
+  # (its mappings need it, but only the controller clears the cache on create)
+  if type == PostType
+    type.clear_ids_cache
+  end
+
   [created, skipped]
 end
 

test/.rubocop.yml

@@ -4,5 +4,8 @@ inherit_from:
 Layout/LineLength:
   Max: 150
 
+Metrics/BlockLength:
+  CountAsOne: ['array']
+
 Metrics/ClassLength:
   Enabled: false

test/helpers/seeds_helper_test.rb

@@ -0,0 +1,11 @@
+require 'test_helper'
+
+class SeedsHelperTest < ActionView::TestCase
+  test 'calling SeedsHelper#files with seed_name should constrain paths' do
+    files = SeedsHelper.files('posts')
+
+    assert_instance_of Array, files
+    assert_equal files.length, 1
+    assert_includes files, "#{Dir.pwd}/db/seeds/posts.yml"
+  end
+end

test/test_helper.rb

@@ -10,6 +10,67 @@
 require 'minitest/ci'
 Minitest::Ci.report_dir = Rails.root.join('test/reports/minitest').to_s
 
+# cleanup seeds after all tests are run (can't use teardown callbacks as they run after each test)
+Minitest.after_run do
+  # IMPORTANT: the order is very specific to prevent FK constraint errors without disabling them
+  models = [
+    WarningTemplate,
+    ModWarning,
+    ThreadFollower,
+    Comment,
+    CommentThread,
+    Reaction,
+    ReactionType,
+    Flag,
+    PinnedLink,
+    PostFlagType,
+    SuggestedEdit,
+    Vote,
+    Post,
+    PostHistory,
+    PostHistoryTag,
+    PostHistoryType,
+    UserAbility,
+    AbilityQueue,
+    Ability,
+    CategoryFilterDefault,
+    Category,
+    CloseReason,
+    PostType,
+    License,
+    TagSynonym,
+    Tag,
+    TagSet,
+    Filter,
+    CommunityUser,
+    UserWebsite,
+    AuditLog,
+    BlockedItem,
+    EmailLog,
+    ErrorLog,
+    Subscription,
+    User,
+    Notification,
+    SiteSetting,
+    Community
+  ]
+
+  models.each do |model|
+    if model == PostType
+      model.unscoped.where.not(answer_type_id: nil).delete_all
+      model.unscoped.where(answer_type_id: nil).delete_all
+    elsif model == Tag
+      model.unscoped.where.not(parent_id: nil).delete_all
+      model.unscoped.where(parent_id: nil).delete_all
+    elsif model == User
+      model.unscoped.where.not(deleted_by_id: nil).delete_all
+      model.unscoped.where(deleted_by_id: nil).delete_all
+    else
+      model.unscoped.all.delete_all
+    end
+  end
+end
+
 Dir.glob(Rails.root.join('test/support/**/*.rb')).sort.each { |f| require f }
 
 class ActiveSupport::TestCase