added tests for the FixRejectedEditStatesTask & simplified it

Author: Oaphi

app/tasks/maintenance/fix_rejected_edit_states_task.rb

@@ -19,7 +19,6 @@ def last_revision_before_decided(edit)
     def initial_revision_before_decided(edit)
       PostHistory.of_type('initial_revision')
                  .where(post: edit.post)
-                 .where(created_at: edit.post.created_at..edit.decided_at)
                  .order(created_at: :desc)
                  .first
     end
@@ -42,18 +41,18 @@ def process(edit)
 
       return unless last_revision.present?
 
-      begin
-        status = edit.update({ before_body: render_markdown(last_revision.after_state),
-                               before_body_markdown: last_revision.after_state,
-                               before_tags: last_revision.after_tags.dup,
-                               before_tags_cache: last_revision.after_tags.map(&:name),
-                               before_title: last_revision.after_title })
-
-        unless status
-          Rails.logger.warn("Failed to fix edit ##{edit.id}")
-        end
-      rescue StandardError => e
-        Rails.logger.warn(e)
+      status = edit.update({ before_body: if last_revision.after_state.present?
+                                            render_markdown(last_revision.after_state)
+                                          else
+                                            edit.before_body
+                                          end,
+                             before_body_markdown: last_revision.after_state,
+                             before_tags: last_revision.after_tags.dup,
+                             before_tags_cache: last_revision.after_tags.map(&:name),
+                             before_title: last_revision.after_title })
+
+      unless status
+        Rails.logger.warn("Failed to fix edit ##{edit.id}")
       end
     end
   end

test/fixtures/post_histories.yml

@@ -14,3 +14,11 @@ question_one_hidden_revision:
   comment: 'A hidden revision made by an admin user'
   community: sample
   hidden: true
+
+question_two_initial_revision:
+  post_history_type: initial_revision
+  user: editor
+  post: question_two
+  community: sample
+  after_state: This is the body of test question two. Note that we did not include any markdown or HTML in here.
+  after_title: Q2 - This is test question number two

test/tasks/maintenance/fix_rejected_edit_states_task_test.rb

@@ -0,0 +1,16 @@
+require 'test_helper'
+
+module Maintenance
+  class FixRejectedEditStatesTaskTest < ActiveSupport::TestCase
+    test 'perform should correctly fix rejected edit states' do
+      edit = suggested_edits(:rejected_suggested_edit)
+
+      Maintenance::FixRejectedEditStatesTask.process(edit)
+      edit.reload
+
+      assert_not_nil edit.before_body
+      assert_not_nil edit.before_body_markdown
+      assert_not_nil edit.before_title
+    end
+  end
+end