Merge pull request #1751 from codidact/0valt/545/silent-tag-rename-fix

Oaphi · web-flow · commit ae0049b997a4 · 2025-08-05T05:56:11.000+03:00
fixed lack of visible error when trying to rename a tag to an invalid…
diff --git a/app/assets/javascripts/tags.js b/app/assets/javascripts/tags.js
@@ -202,7 +202,7 @@ $(() => {
         location.reload();
       }
       else {
-        console.error('Failed to rename tag, somehow');
+        QPixel.createNotification('danger', `Failed to rename the tag. (${resp.status})`);
       }
     }
   });
diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb
@@ -141,7 +141,7 @@ def rename
       end
     end
 
-    render json: { success: status, tag: @tag }
+    render json: { success: status, tag: @tag }, status: status ? :ok : :bad_request
   end
 
   def select_merge; end
diff --git a/test/controllers/tags_controller_test.rb b/test/controllers/tags_controller_test.rb
@@ -215,7 +215,7 @@ class TagsControllerTest < ActionController::TestCase
       tag: tag
     }
 
-    assert_response(:success)
+    assert_response(:bad_request)
     assert_valid_json_response
 
     res_body = JSON.parse(response.body)

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ $(() => {`
`202`	`202`	`location.reload();`
`203`	`203`	`}`
`204`	`204`	`else {`
`205`		`- console.error('Failed to rename tag, somehow');`
	`205`	+ QPixel.createNotification('danger', `Failed to rename the tag. (${resp.status})`);
`206`	`206`	`}`
`207`	`207`	`}`
`208`	`208`	`});`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ class TagsControllerTest < ActionController::TestCase`
`215`	`215`	`tag: tag`
`216`	`216`	`}`
`217`	`217`
`218`		`- assert_response(:success)`
	`218`	`+ assert_response(:bad_request)`
`219`	`219`	`assert_valid_json_response`
`220`	`220`
`221`	`221`	`res_body = JSON.parse(response.body)`