Fix #26 -- Always open files from storage for processing

Author: codingjoe

pictures/tasks.py

@@ -12,12 +12,14 @@
 
 
 def _process_picture(field_file: PictureFieldFile) -> None:
-    field_file.open()  # the file needs to be open
-    with Image.open(field_file.file) as img:
-        for ratio, sources in field_file.aspect_ratios.items():
-            for file_type, srcset in sources.items():
-                for width, picture in srcset.items():
-                    picture.save(img)
+    # field_file.file may already be closed and can't be reopened.
+    # Therefore, we always open it from storage.
+    with field_file.storage.open(field_file.name) as fs:
+        with Image.open(fs) as img:
+            for ratio, sources in field_file.aspect_ratios.items():
+                for file_type, srcset in sources.items():
+                    for width, picture in srcset.items():
+                        picture.save(img)
 
 
 process_picture = _process_picture