Resolve CodeQL warnings

Author: codingjoe

pictures/models.py

@@ -50,7 +50,7 @@ def url(self) -> str:
         return self.storage.url(self.name)
 
     @property
-    def height(self) -> int or None:
+    def height(self) -> int | None:
         if self.aspect_ratio:
             return math.floor(self.width / self.aspect_ratio)
 

pictures/utils.py

@@ -83,6 +83,8 @@ def placeholder(width: int, height: int, alt):
         font_name = "DejaVuSans-Bold"
     elif sys.platform == "darwin":
         font_name = "Helvetica"
+    else:  # pragma: no cover
+        raise RuntimeError(f"Unsupported platform: {sys.platform}")
     font = ImageFont.truetype(font_name, fontsize)
     text = unquote(f"{alt}\n<{width}x{height}>")
     while font.getsize(text)[0] < width / 2:

tests/testapp/__init__.py

@@ -1,6 +1,6 @@
 try:
     from .celery_app import app as celery_app
-
+except ImportError:  # celery is not installed
+    __all__ = []
+else:
     __all__ = ["celery_app"]
-except ImportError:
-    pass

tests/testapp/settings.py

@@ -142,7 +142,7 @@
 # Dramatiq
 try:
     import dramatiq  # NoQA
-except ImportError:
+except ImportError:  # dramatiq is not installed
     pass
 else:
     INSTALLED_APPS += ["django_dramatiq"]