Skip to content

Conversation

@jmsmkn
Copy link
Contributor

@jmsmkn jmsmkn commented Nov 17, 2025

At least the width dimension is always needed to generate the full source set, regardless of the requested aspect ratio. Since only smaller versions of the original file are created, the original size is the upper bound for the source set.

Close #227

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0ec2e4d) to head (81803ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          494       494           
=========================================
  Hits           494       494           
Flag Coverage Δ
celery 85.02% <100.00%> (ø)
cleanup 88.46% <100.00%> (ø)
dj5.1 88.46% <100.00%> (ø)
dj5.2 88.46% <100.00%> (ø)
django-rq 85.02% <100.00%> (ø)
dramatiq 85.02% <100.00%> (ø)
drf 96.35% <100.00%> (ø)
macos-latest 88.66% <100.00%> (ø)
py3.10 88.46% <100.00%> (ø)
py3.12 88.46% <100.00%> (ø)
py3.13 88.46% <100.00%> (ø)
py3.9 88.46% <100.00%> (ø)
ubuntu-latest 88.46% <100.00%> (ø)
windows-latest 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codingjoe codingjoe changed the title Always warn when width and height fields are missing Fix #227 -- Always warn about missing dimension fields (width & height) Nov 28, 2025
@codingjoe codingjoe changed the title Fix #227 -- Always warn about missing dimension fields (width & height) Fix #227 -- Always warn about missing dimension fields Nov 28, 2025
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR message, since this will come as a somewhat breaking change to users. I also updated the documentation in accordance with the fields always being required.

@codingjoe codingjoe merged commit ae4f605 into codingjoe:main Nov 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning fields.E101 only appears when None in aspect ratios

2 participants