Make detail and override views optional

Author: codingjoe

galahad/models.py

@@ -105,7 +105,7 @@ class Meta:
             including start end end not of an edge.
     """
 
-    manual_override = views.ManualOverrideView
+    override_view = views.ManualOverrideView
     detail_view = views.ProcessDetailView
 
     @classmethod
@@ -151,11 +151,14 @@ def urls(cls):
                 else:
                     route = '{name}/<pk>/'.format(name=name)
                 urls.append(path(route, cls._wrap_view_instance(name, node), name=name))
-        urls.extend((
-            path('<pk>/', cls.detail_view.as_view(model=cls),
-                 name='detail'),
-            path('<pk>/override', cls.manual_override.as_view(model=cls), name='override'),
-        ))
+        if cls.detail_view:
+            urls.append(
+                path('<pk>/', cls.detail_view.as_view(model=cls), name='detail')
+            )
+        if cls.override_view:
+            urls.append(
+                path('<pk>/override', cls.override_view.as_view(model=cls), name='override')
+            )
         return urls, cls.get_url_namespace()
 
     @classmethod

tests/test_models.py

@@ -4,7 +4,6 @@
 from django.contrib.auth import get_user_model
 from django.contrib.auth.models import AnonymousUser
 from django.urls import reverse
-from django.utils import timezone
 from django.utils.safestring import SafeString
 from graphviz import Digraph
 
@@ -211,6 +210,61 @@ def test_cancel__with_anonymous_user(self, db):
         process.cancel(user=user)
         assert process.task_set.latest().completed_by_user is None
 
+    def test_urls(self):
+        patterns, namespace = models.SimpleProcess.urls()
+        assert namespace == 'simpleprocess'
+        names = {pattern.name for pattern in patterns}
+        assert names == {
+            'save_the_princess',
+            'start_view',
+            'override',
+            'detail',
+        }
+
+    def test_urls__no_override(self):
+        class TestProcess(Process):
+            override_view = None
+            start = StartView()
+            end = lambda s: None
+
+            edges = (
+                (start, end),
+            )
+
+            class Meta:
+                abstract = True
+                app_label = 'testappp'
+
+        patterns, namespace = TestProcess.urls()
+        assert namespace == 'testprocess'
+        names = {pattern.name for pattern in patterns}
+        assert names == {
+            'start',
+            'detail',
+        }
+
+    def test_urls__no_detail(self):
+        class TestProcess(Process):
+            detail_view = None
+            start = StartView()
+            end = lambda s: None
+
+            edges = (
+                (start, end),
+            )
+
+            class Meta:
+                abstract = True
+                app_label = 'testappp'
+
+        patterns, namespace = TestProcess.urls()
+        assert namespace == 'testprocess'
+        names = {pattern.name for pattern in patterns}
+        assert names == {
+            'start',
+            'override',
+        }
+
 
 class TestTaskQuerySet: