Skip to content

Switch PyPi to OIDC authentication #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

Switch PyPi to OIDC authentication #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,32 @@ name: Release
on:
release:
types: [published]
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The addition of workflow_dispatch trigger enables manual workflow execution, but there's no documentation or comment explaining why this trigger was added or when it should be used. Consider adding a comment to clarify the intended use case for manual triggering.

Suggested change
types: [published]
types: [published]
# Allows maintainers to manually trigger the release workflow if an automated release event fails or a release needs to be published outside the normal process.

Copilot uses AI. Check for mistakes.
workflow_dispatch:
permissions:
id-token: write
jobs:
PyPi:
release-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/setup-python@v6
with:
python-version: "3.x"
- run: python -m pip install --upgrade pip build wheel twine
- run: python -m pip install --upgrade pip build wheel
- run: python -m build --sdist --wheel
- run: python -m twine upload dist/*
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
- uses: actions/upload-artifact@v5
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatched artifact action versions. The workflow uses actions/upload-artifact@v5 for uploading but actions/download-artifact@v6 for downloading. These should use matching major versions to ensure compatibility. Either use @v5 for both or @v6 for both.

Suggested change
- uses: actions/upload-artifact@v5
- uses: actions/upload-artifact@v6

Copilot uses AI. Check for mistakes.
with:
name: release-dists
path: dist/
pypi-publish:
runs-on: ubuntu-latest
needs:
- release-build
permissions:
id-token: write
steps:
- uses: actions/download-artifact@v6
with:
name: release-dists
path: dist/
- uses: pypa/gh-action-pypi-publish@release/v1