Some perfs improvement load Assemblies statically by default.

Sébastien Geiser · Sébastien Geiser · commit d6146f4447b0 · 2019-09-20T16:21:38.000+02:00
+ Some renaming to be clearier.
diff --git a/CodingSeb.ExpressionEvaluator/ExpressionEvaluator.cs b/CodingSeb.ExpressionEvaluator/ExpressionEvaluator.cs
@@ -452,6 +452,8 @@ public static void ClearAllCaches()
 
         #region Assemblies, Namespaces and types lists
 
+        private static readonly IList<Assembly> assemblies = AppDomain.CurrentDomain.GetAssemblies().ToList();
+
         /// <summary>
         /// All assemblies needed to resolves Types
         /// by default all Assemblies loaded in the current AppDomain
@@ -866,7 +868,7 @@ public ExpressionEvaluator(IDictionary<string, object> variables) : this()
 
         protected virtual void AssembliesInit()
         {
-            Assemblies = AppDomain.CurrentDomain.GetAssemblies().ToList();
+            Assemblies = assemblies;
         }
 
         protected virtual void DefaultDecimalSeparatorInit()
@@ -1419,7 +1421,7 @@ public object Evaluate(string expression)
 
             for (int i = 0; i < expression.Length; i++)
             {
-                if (!ParsingMethods.Any(m => m(expression, stack, ref i)))
+                if (!ParsingMethods.Any(parsingMethod => parsingMethod(expression, stack, ref i)))
                 {
                     string s = expression.Substring(i, 1);
 

Original file line number	Diff line number	Diff line change
`@@ -452,6 +452,8 @@ public static void ClearAllCaches()`
`452`	`452`
`453`	`453`	`#region Assemblies, Namespaces and types lists`
`454`	`454`
	`455`	`+ private static readonly IList<Assembly> assemblies = AppDomain.CurrentDomain.GetAssemblies().ToList();`
	`456`	`+`
`455`	`457`	`/// <summary>`
`456`	`458`	`/// All assemblies needed to resolves Types`
`457`	`459`	`/// by default all Assemblies loaded in the current AppDomain`
`@@ -866,7 +868,7 @@ public ExpressionEvaluator(IDictionary<string, object> variables) : this()`
`866`	`868`
`867`	`869`	`protected virtual void AssembliesInit()`
`868`	`870`	`{`
`869`		`- Assemblies = AppDomain.CurrentDomain.GetAssemblies().ToList();`
	`871`	`+ Assemblies = assemblies;`
`870`	`872`	`}`
`871`	`873`
`872`	`874`	`protected virtual void DefaultDecimalSeparatorInit()`
`@@ -1419,7 +1421,7 @@ public object Evaluate(string expression)`
`1419`	`1421`
`1420`	`1422`	`for (int i = 0; i < expression.Length; i++)`
`1421`	`1423`	`{`
`1422`		`- if (!ParsingMethods.Any(m => m(expression, stack, ref i)))`
	`1424`	`+ if (!ParsingMethods.Any(parsingMethod => parsingMethod(expression, stack, ref i)))`
`1423`	`1425`	`{`
`1424`	`1426`	`string s = expression.Substring(i, 1);`
`1425`	`1427`