Only show gh syncer to insiders (exercism#7895)

Author: iHiD

app/helpers/react_components/student/iterations_list.rb

@@ -15,8 +15,7 @@ def to_s
               download_cmd: exercise.download_cmd,
               has_test_runner: exercise.has_test_runner?
             },
-            is_user_lifetime_insider: solution.user.lifetime_insider?,
-            is_user_admin: solution.user.admin?,
+            is_github_syncer_visible: solution.user.insider?,
             track: {
               title: track.title,
               slug: track.slug,

app/helpers/view_components/settings_nav.rb

@@ -8,8 +8,10 @@ def to_s
       items = [
         item_for("Account settings", :settings, :general),
         item_for("API / CLI", :api_cli_settings, :api_cli),
-        item_for("Integrations", :integrations_settings, :integrations),
-        item_for("GitHub Syncer", :settings_github_syncer, :github_syncer),
+        item_for("Integrations", :integrations_settings, :integrations)
+      ]
+      items << item_for("GitHub Syncer", :settings_github_syncer, :github_syncer) if current_user.insider?
+      items += [
         item_for("Preferences", :user_preferences_settings, :preferences),
         item_for("Communication Preferences", :communication_preferences_settings, :communication),
         item_for("Donations", :donations_settings, :donations),

app/javascript/components/student/IterationsList.tsx

@@ -56,8 +56,7 @@ export type IterationsListProps = {
   track: Track
   links: Links
   syncer: GithubSyncerSettings | null
-  isUserLifetimeInsider: boolean
-  isUserAdmin: boolean
+  isGithubSyncerVisible: boolean
 }
 
 export default function IterationsList({
@@ -67,8 +66,7 @@ export default function IterationsList({
   track,
   links,
   syncer,
-  isUserLifetimeInsider,
-  isUserAdmin,
+  isGithubSyncerVisible,
 }: IterationsListProps): JSX.Element {
   const [isOpen, setIsOpen] = useState<boolean[]>([])
 
@@ -169,8 +167,7 @@ export default function IterationsList({
                 iteration={iteration}
                 syncer={syncer}
                 exercise={exercise}
-                isUserLifetimeInsider={isUserLifetimeInsider}
-                isUserAdmin={isUserAdmin}
+                isGithubSyncerVisible={isGithubSyncerVisible}
                 track={track}
                 links={links}
                 isOpen={isOpen[index]}

app/javascript/components/student/iterations-list/Information.tsx

@@ -24,17 +24,15 @@ export const Information = ({
   links,
   onDelete,
   syncer,
-  isUserLifetimeInsider,
-  isUserAdmin,
+  isGithubSyncerVisible,
 }: {
   iteration: Iteration
   exercise: Exercise
   track: Track
   links: Links
   onDelete: (iteration: Iteration) => void
   syncer: GithubSyncerSettings | null
-  isUserLifetimeInsider: boolean
-  isUserAdmin: boolean
+  isGithubSyncerVisible: boolean
 }): JSX.Element | null => {
   const [tab, setTab] = useState<TabIndex>('analysis')
 
@@ -54,7 +52,7 @@ export const Information = ({
           <GraphicalIcon icon="tests" />
           Tests
         </Tab>
-        {isUserAdmin && (
+        {isGithubSyncerVisible && (
           <Tab id="github-backup" context={TabsContext} className="--small">
             <GraphicalIcon icon="external-site-github" />
             Backup

app/javascript/components/student/iterations-list/IterationReport.tsx

@@ -18,8 +18,7 @@ export const IterationReport = ({
   onCompressed,
   onDelete,
   syncer,
-  isUserLifetimeInsider,
-  isUserAdmin,
+  isGithubSyncerVisible,
 }: {
   iteration: Iteration
   exercise: Exercise
@@ -30,8 +29,7 @@ export const IterationReport = ({
   onCompressed: () => void
   onDelete: (iteration: Iteration) => void
   syncer: GithubSyncerSettings | null
-  isUserLifetimeInsider: boolean
-  isUserAdmin: boolean
+  isGithubSyncerVisible: boolean
 }): JSX.Element => {
   return (
     <details open={isOpen} className="iteration c-details">
@@ -83,8 +81,7 @@ export const IterationReport = ({
           </div>
           <div className="information">
             <Information
-              isUserLifetimeInsider={isUserLifetimeInsider}
-              isUserAdmin={isUserAdmin}
+              isGithubSyncerVisible={isGithubSyncerVisible}
               iteration={iteration}
               exercise={exercise}
               track={track}