[cdt-98] - some fixes

Signed-off-by: ashish <[email protected]>

Author: pateash

src/commands/view.ts

@@ -1,5 +1,6 @@
 // code here to write the tool for csv tool show
 import {Command, flags} from '@oclif/command'
+import * as chalk from 'chalk'
 
 import Logger from '../utilities/logger'
 import Utilities from '../utilities/utilities'
@@ -11,7 +12,7 @@ export default class View extends Command {
   static flags = {
     help: flags.help({char: 'h'}),
     file: flags.string({char: 'f' , description: 'formatted file to be shown'}),
-    num: flags.string({char: 'n' , description: 'rows to show'})
+    num: flags.string({char: 'n' , description: `no. of rows to show, default:${View.DEFAULT_COUNT}`})
   }
 
   static args = [{name: 'file'}]
@@ -74,13 +75,19 @@ export default class View extends Command {
       }
     }
 
+    // -1 need to be done to exclude header
+    // ${chalk.yellow('Avro Schema')
+    Logger.info(this, `Total ${chalk.greenBright(rows.length - 2)} records in file.`)
+    Logger.info(this, `showing top ${chalk.yellow(recordsToShow - 1)} records.`)
+
     this.printRow(rows[0].split(','), widthArray, '+', true)
     for (let i = 0; i < recordsToShow; i++) {
       let row = rows[i]
       this.printRow(row.split(','), widthArray, '|', false)
       this.printRow(row.split(','), widthArray, '+', true)
     }
-    this.log(`showing top ${recordsToShow} rows.`)
+
+    Logger.success(this, 'done.\n')
   }
 
   private printRow(row: any, widthArray: any, seperator: any, isLineSeparator: any) {

test/commands/view.test.ts

@@ -24,7 +24,7 @@ describe('view', () => {
 
   test
     .stdout()
-    .command (['view', 'test/resources/csv/test_view.csv', '-n', '900'])
+    .command(['view', 'test/resources/csv/test_view.csv', '-n', '900'])
     .it('check if the given number is greater than total lines', ctx => {
       expect(ctx.stdout).to.contain('|0       |3     |0  |32.0             |7.75    |0           |0        |')
     })

test/resources/csv/test_view_small.csv

@@ -0,0 +1,14 @@
+Survived,Pclass,Sex,Age,Fare,Family_count,Cabin_ind
+0,3,0,22.0,7.25,1,0
+1,1,1,38.0,71.2833,1,1
+1,3,1,26.0,7.925,0,0
+1,1,1,35.0,53.1,1,1
+0,3,0,35.0,8.05,0,0
+0,3,0,29.69911764705882,8.4583,0,0
+0,1,0,54.0,51.8625,0,1
+0,3,0,2.0,21.075,4,0
+1,3,1,27.0,11.1333,2,0
+1,2,1,14.0,30.0708,1,0
+1,3,1,4.0,16.7,2,1
+1,1,1,58.0,26.55,0,1
+0,3,0,20.0,8.05,0,0