Revert "Use trusted publishing, modernized linter setup"

This reverts commit 63a151f.

Author: Zoran Simic

.github/workflows/release.yml

@@ -9,19 +9,19 @@ jobs:
   publish:
 
     runs-on: ubuntu-latest
-    environment: release
-    permissions:
-      id-token: write  # mandatory for trusted publishing
 
     steps:
     - uses: actions/checkout@v4
     - uses: actions/setup-python@v5
       with:
         python-version: "3.11"
 
-    - run: pip install -U pip setuptools wheel tox
+    - run: pip install -U pip setuptools wheel twine 'tox<4'
     - run: tox -e py,docs,style
     - run: python setup.py sdist bdist_wheel
 
-    - name: Publish to PyPI
-      uses: pypa/gh-action-pypi-publish@release/v1
+    - name: Publish sdist and wheel
+      env:
+        TWINE_USERNAME: __token__
+        TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
+      run: twine upload --non-interactive dist/*

pyproject.toml

@@ -1,6 +1,5 @@
 [build-system]
 requires = ["setuptools", "wheel"]
-build-backend = "setuptools.build_meta"
 
 [tool.ruff]
 cache-dir = ".tox/.ruff_cache"
@@ -10,7 +9,7 @@ src = ["src", "tests"]
 [tool.ruff.lint]
 extend-select = [
     "A",   # flake8-builtins
-    "ARG", # flake8-unused-arguments
+#    "ARG", # flake8-unused-arguments
     "B",   # flake8-bugbear
     "C4",  # flake8-comprehensions
     "C90", # mccabe
@@ -34,16 +33,33 @@ extend-select = [
     "RET", # flake8-return
     "RUF", # ruff-specific
     "S",   # flake8-bandit
-    "SIM", # flake8-simplify
+#    "SIM", # flake8-simplify
     "SLF", # flake8-self
     "SLOT", # flake8-slots
     "T10", # flake8-debugger
     "TID", # flake8-tidy-imports
     "TCH", # flake8-type-checking
-    "TD", # flake8-todos
+#    "TD", # flake8-todos
     "TRY", # tryceratops
     "W",   # pycodestyle warnings
 ]
+ignore = [
+    # TODO: gradually remove these (document all the things)
+    "D100",  # Missing docstring in public module
+    "D101",  # Missing docstring in public class
+    "D102",  # Missing docstring in public method
+    "D103",  # Missing docstring in public function
+    "D104",  # Missing docstring in public package
+    "D105",  # Missing docstring in magic method
+    "D200",  # One-line docstring should fit on one line with quotes
+    "D205",  # 1 blank line required between summary line and description
+    "D400",  # First line should end with a period
+    # Not useful:
+    "RET503",  # Missing explicit `return` at the end of function able to return non-`None` value
+]
+
+[tool.ruff.lint.flake8-builtins]
+builtins-ignorelist = ["bin", "compile"]
 
 [tool.ruff.lint.isort]
 order-by-type = false
@@ -53,3 +69,8 @@ max-complexity = 14
 
 [tool.ruff.lint.pydocstyle]
 convention = "numpy"
+
+[tool.ruff.lint.per-file-ignores]
+"tests/*" = [
+    "S",  # No security checks for tests
+]

tox.ini

@@ -7,7 +7,7 @@ setenv = COVERAGE_FILE={toxworkdir}/.coverage.{envname}
 usedevelop = True
 deps = -rrequirements.txt
        -rtests/requirements.txt
-commands = pytest {posargs:-vv --cov=src/ --cov=tests/ --cov-report=xml tests/}
+commands = pytest {posargs:-vv --cov=src/ --cov-report=xml tests/}
 
 [testenv:coverage]
 setenv = COVERAGE_FILE={toxworkdir}/.coverage
@@ -21,14 +21,15 @@ commands = coverage combine
 [testenv:style]
 skip_install = True
 deps = ruff
-commands = ruff check
+commands = ruff check --diff
+           ruff check --output-format=full
            ruff format --diff
 
 [testenv:reformat]
 skip_install = True
 deps = ruff
-commands = ruff check --fix
-           ruff format
+commands = ruff check --fix {posargs:}
+           ruff format {posargs:}
 
 [testenv:docs]
 skip_install = True