Skip to content

Remove double representation of data in several places #41

@codyduong

Description

@codyduong

We double represent some data, this was originally meant as a convenience but may not accurately represent the gtk4 state, or it may be an unnecessary double storage of values.

pub struct Base {
  // pub classes: Vec<String>,
  // pub classes_temp: Vec<String>,
  pub halign: Option<Align>,
  pub hexpand: bool,
  pub valign: Option<Align>,
  pub vexpand: bool,
}
pub struct BoxInner {
  // pub base: Base,
  pub homogeneous: Option<bool>,
  // pub widgets: Vec<WidgetController>,
}

And so on... Notably, we do need to keep these for Reactives so is it worth the effort to remove these if we end up supporting reactive broadly? Instead maybe we should consider not adding it to new props as was done in 88002c2, but keep existing ones?

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestquestionFurther information is requested

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions