Fix default parser logic in ParsingPipelineFactory;

Add progress callback to data source processing in ParsingPipeline

Author: coffeegist

bofhound/__main__.py

@@ -118,7 +118,10 @@ def main(
     pipeline = ParsingPipelineFactory.create_pipeline(parser_type=parser_type)
 
     with console.status("", spinner="aesthetic") as status:
-        results = pipeline.process_data_source(data_source)
+        results = pipeline.process_data_source(
+            data_source,
+            progress_callback=lambda id: status.update(f"Processing {id}")
+        )
 
     ldap_objects = results.get_ldap_objects()
     local_objects = results.get_local_group_memberships() + results.get_sessions() + \

bofhound/parsers/parsing_pipeline.py

@@ -57,7 +57,7 @@ def register_parser(self, parser: ToolParser):
         """Register a tool parser with the pipeline"""
         self.tool_parsers.append(parser)
 
-    def process_data_source(self, data_source: DataSource) -> ParsingResult:
+    def process_data_source(self, data_source: DataSource, progress_callback=None) -> ParsingResult:
         """
         Process a data source through all registered parsers.
 
@@ -66,6 +66,8 @@ def process_data_source(self, data_source: DataSource) -> ParsingResult:
         result = ParsingResult()
 
         for data_stream in data_source.get_data_streams():
+            if progress_callback:
+                progress_callback(data_stream.identifier)
             for line in data_stream.lines():
                 # Apply platform-specific filtering
                 filtered_line = line.rstrip('\n\r')
@@ -116,9 +118,9 @@ def create_pipeline(parser_type: ParserType = ParserType.LdapsearchBof) -> Parsi
         pipeline.register_parser(NetSessionBofParser())
         pipeline.register_parser(NetLocalGroupBofParser())
         pipeline.register_parser(RegSessionBofParser())
-        if parser_type == ParserType.LdapsearchBof:
-            pipeline.register_parser(LdapSearchBofParser())
-        elif parser_type == ParserType.BRC4:
+        if parser_type == ParserType.BRC4:
             pipeline.register_parser(Brc4LdapSentinelParser())
+        else:
+            pipeline.register_parser(LdapSearchBofParser())
 
         return pipeline