Skip to content

Fix plugin can hang if stderr is larger than OS IO buffer #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overheadhunter merged 1 commit into from
Jan 9, 2026
Merged

Fix plugin can hang if stderr is larger than OS IO buffer #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/main/java/io/github/coffeelibs/maven/jextract/SourcesMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@

import java.io.File;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.CompletableFuture;

@SuppressWarnings({"unused", "MismatchedReadAndWriteOfArray"})
@Mojo(name = "sources", defaultPhase = LifecyclePhase.GENERATE_SOURCES, threadSafe = true, requiresOnline = true)
Expand Down Expand Up @@ -215,9 +217,25 @@ public void execute() throws MojoFailureException {
try (var stdout = new LoggingOutputStream(getLog()::info, StandardCharsets.UTF_8);
var stderr = new LoggingOutputStream(getLog()::warn, StandardCharsets.UTF_8)) {
Process process = command.start();
process.getInputStream().transferTo(stdout);
process.getErrorStream().transferTo(stderr);

final var stdoutFuture = CompletableFuture.runAsync(() -> {
try {
process.getInputStream().transferTo(stdout);
} catch (IOException e) {
throw new UncheckedIOException("Error while writing jextract stdout to logs", e);
}
});

final var stderrFuture = CompletableFuture.runAsync(() -> {
try {
process.getErrorStream().transferTo(stderr);
} catch (IOException e) {
throw new UncheckedIOException("Error while writing jextract stderr to logs", e);
}
});

int result = process.waitFor();
CompletableFuture.allOf(stdoutFuture, stderrFuture).join();
if (result != 0) {
throw new MojoFailureException("jextract returned error code " + result);
}
Expand Down