Shifted the blog storage connection string to the AzureSettings class, as it makes for neater and easier to read config.

Author: HeyJoel

README.md

@@ -15,8 +15,8 @@ This library contains services, abstractions and helpers for running in an Azure
 
 ## Settings
 
-- **Cofoundry:Plugins:AzureBlobFileService:ConnectionString** The connection string to use when accessing files in blob storage
-- **Cofoundry:Plugins:Azure:AutoRegisterServices:** Indicates whether to automatically register azure services. Defaults to true, but you may want to set this as false if developing locally 
+- **Cofoundry:Plugins:Azure:BlobStorageConnectionString** The connection string to use when accessing files in blob storage.
+- **Cofoundry:Plugins:Azure:Disabled:** Indicates whether the plugin should be disabled, which means services will not be bootstrapped. Disable this in dev when you want to run using the standard non-cloud services. Defaults to false.
 
 
 

src/Cofoundry.Plugins.Azure/AzureBlobFileService.cs

@@ -25,17 +25,17 @@ public class AzureBlobFileService : IFileStoreService
         private static ConcurrentBag<string> _initializedContainers2 = new ConcurrentBag<string>();
 
         public AzureBlobFileService(
-            AzureBlobFileServiceSettings settings
+            AzureSettings settings
             )
         {
             if (settings == null) throw new ArgumentNullException(nameof(settings));
 
-            if (string.IsNullOrWhiteSpace(settings.ConnectionString))
+            if (string.IsNullOrWhiteSpace(settings.BlobStorageConnectionString))
             {
-                throw new InvalidConfigurationException(typeof(AzureBlobFileServiceSettings), "The ConnectionString is required to use the AzureBlobFileService");
+                throw new InvalidConfigurationException(typeof(AzureSettings), "The BlobStorageConnectionString is required to use the AzureBlobFileService");
             }
 
-            var storageAccount = CloudStorageAccount.Parse(settings.ConnectionString);
+            var storageAccount = CloudStorageAccount.Parse(settings.BlobStorageConnectionString);
             _blobClient = storageAccount.CreateCloudBlobClient();
         }
 

src/Cofoundry.Plugins.Azure/AzureBlobFileServiceSettings.cs

@@ -14,11 +14,6 @@ public class AzureDependencyRegistration : IDependencyRegistration
     {
         public void Register(IContainerRegister container)
         {
-            container
-                .RegisterFactory<AzureBlobFileServiceSettings, ConfigurationSettingsFactory<AzureBlobFileServiceSettings>>()
-                .RegisterFactory<AzureSettings, ConfigurationSettingsFactory<AzureSettings>>()
-                ;
-
             if (container.Configuration.IsAzurePluginEnabled())
             {
                 var delayedRegistrationOptions = RegistrationOptions.Override();

src/Cofoundry.Plugins.Azure/AzureDependencyRegistration.cs

@@ -11,9 +11,14 @@ public class AzureSettings : PluginConfigurationSettingsBase
     {
         /// <summary>
         /// Indicates whether the plugin should be disabled, which means services
-        /// will not be boostrapped. Disable this in dev when you want to run using
-        /// the standard non-cloud services.
+        /// will not be bootstrapped. Disable this in dev when you want to run using
+        /// the standard non-cloud services. Defaults to false.
         /// </summary>
         public bool Disabled { get; set; }
+
+        /// <summary>
+        /// The connection string to use when accessing files in blob storage
+        /// </summary>
+        public string BlobStorageConnectionString { get; set; }
     }
 }