- Updated to Cofoundry v0.10 pre-release

- Added some additional validation around recurring task intervals.

Author: HeyJoel

src/Cofoundry.Plugins.BackgroundTasks.Hangfire/Cofoundry.Plugins.BackgroundTasks.Hangfire.csproj

@@ -15,7 +15,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Cofoundry.Web" Version="0.9.2" />
-    <PackageReference Include="Hangfire" Version="1.7.24" />
+    <PackageReference Include="Cofoundry.Web" Version="0.9.3-reworking-user-a0099" />
+    <PackageReference Include="Hangfire" Version="1.7.28" />
   </ItemGroup>
 </Project>

src/Cofoundry.Plugins.BackgroundTasks.Hangfire/HangfireBackgroundTaskScheduler.cs

@@ -1,17 +1,11 @@
-using Hangfire;
+using Cofoundry.Core.BackgroundTasks;
+using Hangfire;
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-using Cofoundry.Core.BackgroundTasks;
 
 namespace Cofoundry.Plugins.BackgroundTasks.Hangfire
 {
     public class HangfireBackgroundTaskScheduler : IBackgroundTaskScheduler
     {
-        #region public methods
-
         public IBackgroundTaskScheduler RegisterRecurringTask<TTask>(int days, int atHour, int atMinute) where TTask : IRecurringBackgroundTask
         {
             ValidateDailyTaskParameters(days, atHour, atMinute);
@@ -110,10 +104,6 @@ public IBackgroundTaskScheduler DeregisterAsyncRecurringTask<TTask>() where TTas
             return this;
         }
 
-        #endregion
-
-        #region private methods
-
         private string GetJobId<TTask>()
         {
             return typeof(TTask).FullName;
@@ -151,6 +141,15 @@ private void ValidateHourlyTaskParameters(int hours, int minute)
                 throw new ArgumentOutOfRangeException(nameof(hours), "Recurring tasks need to have an interval of at least 1 minute.");
             }
 
+            if (hours > 23)
+            {
+                throw new ArgumentOutOfRangeException(nameof(hours), "Recurring tasks with an interval of 24 hours or more should be scheduled using a daily interval instead.");
+            }
+
+            if (minute > 59)
+            {
+                throw new ArgumentOutOfRangeException(nameof(hours), "Recurring tasks with an interval measured in hours and minutes cannot have an minute component greater than 59 minutes.");
+            }
         }
 
         private void ValidateMinuteTaskParameters(int minutes)
@@ -169,7 +168,5 @@ private void ValidateNotNegative(int number, string argumentName)
                 throw new ArgumentOutOfRangeException(argumentName, "Recurring tasks cannot set the interval to negative numbers.");
             }
         }
-
-        #endregion
     }
 }

src/HangfireSample/HangfireSample.csproj

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Cofoundry.Web.Admin" Version="0.9.2" />
+    <PackageReference Include="Cofoundry.Web.Admin" Version="0.9.3-reworking-user-a0099" />
   </ItemGroup>
 
   <ItemGroup>