Merge pull request #5 from erikdubbelboer/fix-RenderPassEncoder-End

kkoreilly · web-flow · commit e22653466f83 · 2025-05-19T10:24:58.000-07:00
Make RenderPassEncoder.End() the same for different builds
diff --git a/wgpu/render_pass_js.go b/wgpu/render_pass_js.go
@@ -81,8 +81,9 @@ func (g RenderPassEncoder) DrawIndexed(indexCount uint32, instanceCount uint32,
 
 // End as described:
 // https://gpuweb.github.io/gpuweb/#dom-gpurenderpassencoder-end
-func (g RenderPassEncoder) End() {
+func (g RenderPassEncoder) End() error {
 	g.jsValue.Call("end")
+	return nil
 }
 
 func (g RenderPassEncoder) Release() {} // no-op

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,9 @@ func (g RenderPassEncoder) DrawIndexed(indexCount uint32, instanceCount uint32,`
`81`	`81`
`82`	`82`	`// End as described:`
`83`	`83`	`// https://gpuweb.github.io/gpuweb/#dom-gpurenderpassencoder-end`
`84`		`-func (g RenderPassEncoder) End() {`
	`84`	`+func (g RenderPassEncoder) End() error {`
`85`	`85`	`g.jsValue.Call("end")`
	`86`	`+ return nil`
`86`	`87`	`}`
`87`	`88`
`88`	`89`	`func (g RenderPassEncoder) Release() {} // no-op`