Skip to content

Commit 402c744

Browse files
refactor: make pause/resume test self-contained
- Remove dependency on permanent_workflow_for_triggers fixture - Create and clean up our own temporary workflow in the test - Makes test simpler, more predictable, and easier to understand - Follows pattern used by other tests in the file
1 parent 1de632a commit 402c744

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

tests/tests_integration/test_api/test_workflows.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -762,16 +762,17 @@ def test_trigger_run_history_non_existing(self, cognite_client: CogniteClient) -
762762
external_id="integration_test-non_existing_trigger"
763763
)
764764

765-
def test_pause_resume_trigger(
766-
self,
767-
cognite_client: CogniteClient,
768-
permanent_workflow_for_triggers: WorkflowVersion,
769-
) -> None:
765+
def test_pause_resume_trigger(self, cognite_client: CogniteClient) -> None:
766+
# Create a temporary workflow for this test
767+
workflow_external_id = f"integration_test-pause_resume_workflow-{int(time.time())}"
768+
workflow = WorkflowUpsert(external_id=workflow_external_id)
769+
created_workflow = cognite_client.workflows.upsert(workflow)
770+
770771
trigger_external_id = f"integration_test-pause_resume_trigger-{int(time.time())}"
771772
trigger_upsert = WorkflowTriggerUpsert(
772773
external_id=trigger_external_id,
773-
workflow_external_id=permanent_workflow_for_triggers.workflow_external_id,
774-
workflow_version=permanent_workflow_for_triggers.version,
774+
workflow_external_id=created_workflow.external_id,
775+
workflow_version=created_workflow.version,
775776
trigger_rule=WorkflowScheduledTriggerRule(cron_expression="0 0 * * *"),
776777
)
777778

@@ -802,10 +803,15 @@ def test_pause_resume_trigger(
802803
assert trigger_still_resumed.is_paused is False
803804

804805
finally:
806+
# Clean up trigger and workflow
805807
try:
806808
cognite_client.workflows.triggers.delete(trigger_external_id)
807809
except Exception:
808810
pass
811+
try:
812+
cognite_client.workflows.delete(workflow_external_id)
813+
except Exception:
814+
pass
809815

810816
def test_pause_resume_nonexistent_trigger(self, cognite_client: CogniteClient) -> None:
811817
# Test pause on non-existent trigger

0 commit comments

Comments
 (0)