Skip to content

Commit 754a99a

Browse files
authored
Merge branch 'master' into DOG-5440-db-extractor-fails-to-update-extractor-pipeline-in-case-of-message-longer-than-1000-characters
2 parents 0c074e3 + ac184d5 commit 754a99a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

cognite/extractorutils/configtools/loaders.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
import dacite
2929
import yaml
30+
from azure.core.credentials import TokenCredential
3031
from azure.core.exceptions import HttpResponseError, ResourceNotFoundError, ServiceRequestError
3132
from azure.identity import ClientSecretCredential, DefaultAzureCredential
3233
from azure.keyvault.secrets import SecretClient
@@ -64,7 +65,6 @@ class KeyVaultLoader:
6465
def __init__(self, config: dict | None):
6566
self.config = config
6667

67-
self.credentials: DefaultAzureCredential | ClientSecretCredential | None = None
6868
self.client: SecretClient | None = None
6969

7070
def _init_client(self) -> None:
@@ -88,9 +88,10 @@ def _init_client(self) -> None:
8888

8989
vault_url = f"https://{keyvault_name}.vault.azure.net"
9090

91+
credentials: TokenCredential
9192
if self.config["authentication-method"] == KeyVaultAuthenticationMethod.DEFAULT.value:
9293
_logger.info("Using Azure DefaultCredentials to access KeyVault")
93-
self.credentials = DefaultAzureCredential()
94+
credentials = DefaultAzureCredential()
9495

9596
elif self.config["authentication-method"] == KeyVaultAuthenticationMethod.CLIENTSECRET.value:
9697
auth_parameters = ("client-id", "tenant-id", "secret")
@@ -107,7 +108,7 @@ def _init_client(self) -> None:
107108
client_id = os.path.expandvars(self.config["client-id"])
108109
secret = os.path.expandvars(self.config["secret"])
109110

110-
self.credentials = ClientSecretCredential(
111+
credentials = ClientSecretCredential(
111112
tenant_id=tenant_id,
112113
client_id=client_id,
113114
client_secret=secret,
@@ -121,7 +122,7 @@ def _init_client(self) -> None:
121122
"Invalid KeyVault authentication method. Possible values : default or client-secret"
122123
)
123124

124-
self.client = SecretClient(vault_url=vault_url, credential=self.credentials)
125+
self.client = SecretClient(vault_url=vault_url, credential=credentials)
125126

126127
def __call__(self, _: yaml.SafeLoader, node: yaml.Node) -> str:
127128
self._init_client()

0 commit comments

Comments
 (0)