[CDF-27420] Validate SearchConfig referenced view in build v2 (#2775)

# Description

`SearchConfig.yaml` could reference a view that does not exist without
Toolkit reporting it.

`SearchConfigCRUD` did not declare a view dependency, so build v2
dependency validation did not include SearchConfig view references.

This change:

- Declares the configured view as a `ViewCRUD` dependency via
`SearchConfigCRUD.get_dependencies`.
- Implements `ViewId`/`ViewNoVersionId` equality and hash behavior so
no-version view references match versioned views in dependency checks.
- Adds focused unit tests for SearchConfig dependency validation and
identifier equality behavior.

## Bump

- [x] Patch
- [ ] Skip

## Changelog

### Fixed

- SearchConfig (build v2): emit `MISSING-DEPENDENCY` when the referenced
data modeling view is missing from the build output and from CDF.

---------

Co-authored-by: anders-albert <anders0albert@gmail.com>

Author: ronpal

cognite_toolkit/_cdf_tk/client/identifiers/_data_modeling.py

@@ -85,10 +85,29 @@ def _as_filename(self, include_type: bool = False) -> str:
             return f"space-{self.space}.externalId-{self.external_id}"
         return f"{self.space}.{self.external_id}"
 
+    def __eq__(self, other: Any) -> bool:
+        if isinstance(other, ViewNoVersionId):
+            return self.space == other.space and self.external_id == other.external_id
+        return NotImplemented
+
+    def __hash__(self) -> int:
+        return hash((self.space, self.external_id))
+
 
 class ViewId(ViewNoVersionId):
     version: str
 
+    def __eq__(self, other: Any) -> bool:
+        if isinstance(other, ViewId):
+            return self.space == other.space and self.external_id == other.external_id and self.version == other.version
+        if isinstance(other, ViewNoVersionId):
+            return self.space == other.space and self.external_id == other.external_id
+        return NotImplemented
+
+    def __hash__(self) -> int:
+        # Keep hash aligned with equality against ViewNoVersionId.
+        return hash((self.space, self.external_id))
+
     def __str__(self) -> str:
         return f"{self.space}:{self.external_id}(version={self.version})"
 

cognite_toolkit/_cdf_tk/cruds/_resource_cruds/configuration.py

@@ -5,6 +5,7 @@
 from rich.console import Console
 
 from cognite_toolkit._cdf_tk.client import ToolkitClient
+from cognite_toolkit._cdf_tk.client._resource_base import Identifier
 from cognite_toolkit._cdf_tk.client.resource_classes.data_modeling import ViewNoVersionId
 from cognite_toolkit._cdf_tk.client.resource_classes.group import (
     AclType,
@@ -66,6 +67,10 @@ def dump_id(cls, id: ViewNoVersionId) -> dict[str, Any]:
     def as_str(cls, id: ViewNoVersionId) -> str:
         return sanitize_filename(f"{id.external_id}_{id.space}")
 
+    @classmethod
+    def get_dependencies(cls, resource: SearchConfigYAML) -> Iterable[tuple[type[ResourceCRUD], Identifier]]:
+        yield ViewCRUD, resource.as_id()
+
     def dump_resource(self, resource: SearchConfigResponse, local: dict[str, Any] | None = None) -> dict[str, Any]:
         dumped = resource.as_request_resource().dump()
         local = local or {}

tests/test_unit/test_cdf_tk/test_client/test_identifiers.py

@@ -3,7 +3,7 @@
 from cognite_toolkit._cdf_tk.client._resource_base import Identifier
 
 # Import one of the concrete Identifier subclasses to ensure they are registered in the test
-from cognite_toolkit._cdf_tk.client.identifiers import EdgeTypeId, NodeId
+from cognite_toolkit._cdf_tk.client.identifiers import EdgeTypeId, NodeId, ViewId, ViewNoVersionId
 
 
 class TestIdentifiers:
@@ -25,3 +25,14 @@ def test_validate_str(self) -> None:
         edge_type = EdgeTypeId(type=NodeId(space="test_space", external_id="test_external_id"), direction="outwards")
 
         assert edge_type == EdgeTypeId.model_validate(str(edge_type))
+
+
+class TestViewIdEquality:
+    def test_view_no_version_equals_versioned_view(self) -> None:
+        v1 = ViewId(space="test_space", external_id="test_external_id", version="v1")
+        v2 = ViewId(space="test_space", external_id="test_external_id", version="v2")
+        no_version = ViewNoVersionId(space=v1.space, external_id=v1.external_id)
+
+        assert v1 != v2
+        assert no_version == v1
+        assert v2 == no_version

tests/test_unit/test_cdf_tk/test_commands/test_buildv2/test_command.py

@@ -8,14 +8,19 @@
 
 from cognite_toolkit._cdf_tk.client._toolkit_client import ToolkitClient
 from cognite_toolkit._cdf_tk.client.config import ToolkitClientConfig
+from cognite_toolkit._cdf_tk.client.identifiers import ViewId, ViewNoVersionId
 from cognite_toolkit._cdf_tk.commands import BuildV2Command
 from cognite_toolkit._cdf_tk.commands.build_v2.data_classes import BuildParameters, RelativeDirPath
+from cognite_toolkit._cdf_tk.commands.build_v2.data_classes._build import BuiltModule, BuiltResource
 from cognite_toolkit._cdf_tk.commands.build_v2.data_classes._module import (
     FailedReadYAMLFile,
+    ModuleId,
+    ResourceType,
     SuccessfulReadYAMLFile,
 )
+from cognite_toolkit._cdf_tk.commands.build_v2.data_classes._types import AbsoluteDirPath, AbsoluteFilePath
 from cognite_toolkit._cdf_tk.constants import MODULES
-from cognite_toolkit._cdf_tk.cruds import SpaceCRUD
+from cognite_toolkit._cdf_tk.cruds import SearchConfigCRUD, SpaceCRUD
 from cognite_toolkit._cdf_tk.cruds._base_cruds import ResourceContainerCRUD, ResourceCRUD
 from cognite_toolkit._cdf_tk.cruds._resource_cruds.datamodel import DataModelCRUD, ViewCRUD
 from cognite_toolkit._cdf_tk.cruds._resource_cruds.workflow import WorkflowCRUD
@@ -192,6 +197,54 @@ def test_end_to_end_invalid_space_emits_syntax_warning(self, tmp_path: Path, tlk
         }
 
 
+class TestDependencyValidationSearchConfig:
+    @staticmethod
+    def _minimal_module(tmp_path: Path) -> tuple[BuiltModule, Path, Path]:
+        mod_path = tmp_path / "modules" / "my"
+        mod_path.mkdir(parents=True)
+        source_file = mod_path / "1-x.SearchConfig.yaml"
+        source_file.touch()
+        build_file = mod_path / "1-x-out.SearchConfig.yaml"
+        build_file.touch()
+        module = BuiltModule(
+            module_id=ModuleId(id=RelativeDirPath(Path("modules/my")), path=AbsoluteDirPath(mod_path.resolve())),
+            resources=[],
+        )
+        return module, source_file, build_file
+
+    def test_search_config_dependency_satisfied_by_local_view(self, tmp_path: Path) -> None:
+        module, source_file, build_file = self._minimal_module(tmp_path)
+        view_ref = ViewNoVersionId(space="my_space", external_id="View1")
+        module.resources.append(
+            BuiltResource(
+                identifier=ViewId(space="my_space", external_id="View1", version="v1"),
+                source_hash="h-view",
+                type=ResourceType(resource_folder=ViewCRUD.folder_name, kind=ViewCRUD.kind),
+                source_path=AbsoluteFilePath(source_file.resolve()),
+                build_path=AbsoluteFilePath(build_file.resolve()),
+                crud_cls=ViewCRUD,
+                dependencies=set(),
+            )
+        )
+        module.resources.append(
+            BuiltResource(
+                identifier=view_ref,
+                source_hash="h",
+                type=ResourceType(
+                    resource_folder=SearchConfigCRUD.folder_name,
+                    kind=SearchConfigCRUD.kind,
+                ),
+                source_path=AbsoluteFilePath(source_file.resolve()),
+                build_path=AbsoluteFilePath(build_file.resolve()),
+                crud_cls=SearchConfigCRUD,
+                dependencies={(ViewCRUD, view_ref)},
+            )
+        )
+
+        insights = BuildV2Command()._dependency_validation([module], None)
+        assert not any(getattr(i, "code", None) == "MISSING-DEPENDENCY" for i in insights)
+
+
 class TestValidateBuildParameters:
     @pytest.mark.parametrize(
         "paths, parameters, user_args, expected_error",