remove file limit (#745)

* fix

* remove limits tests

Author: scott-cohere

src/backend/routers/agent.py

@@ -51,7 +51,6 @@
 from backend.services.file import (
     consolidate_agent_files_in_compass,
     get_file_service,
-    validate_batch_file_size,
     validate_file,
 )
 from backend.services.request_validators import (
@@ -686,7 +685,6 @@ async def batch_upload_file(
     ctx: Context = Depends(get_context),
 ) -> UploadAgentFileResponse:
     user_id = ctx.get_user_id()
-    validate_batch_file_size(session, user_id, files)
 
     uploaded_files = []
     try:

src/backend/routers/conversation.py

@@ -37,7 +37,6 @@
 from backend.services.file import (
     attach_conversation_id_to_files,
     get_file_service,
-    validate_batch_file_size,
     validate_file,
 )
 
@@ -346,7 +345,6 @@ async def batch_upload_file(
     """
 
     user_id = ctx.get_user_id()
-    validate_batch_file_size(session, user_id, files)
 
     # Create new conversation
     if not conversation_id:

src/backend/services/file.py

@@ -738,62 +738,3 @@ def read_docx(file_contents: bytes) -> str:
         text += paragraph.text + "\n"
 
     return text
-
-
-def validate_file_size(
-    session: DBSessionDep, user_id: str, file: FastAPIUploadFile
-) -> None:
-    """Validates the file size
-
-    Args:
-        user_id (str): The user ID
-        file (UploadFile): The file to validate
-
-    Raises:
-        HTTPException: If the file size is too large
-    """
-    if file.size > MAX_FILE_SIZE:
-        raise HTTPException(
-            status_code=400,
-            detail=f"File size exceeds the maximum allowed size of {MAX_FILE_SIZE} bytes.",
-        )
-
-    existing_files = file_crud.get_files_by_user_id(session, user_id)
-    total_file_size = sum([f.file_size for f in existing_files]) + file.size
-
-    if total_file_size > MAX_TOTAL_FILE_SIZE:
-        raise HTTPException(
-            status_code=400,
-            detail=f"Total file size exceeds the maximum allowed size of {MAX_TOTAL_FILE_SIZE} bytes.",
-        )
-
-
-def validate_batch_file_size(
-    session: DBSessionDep, user_id: str, files: list[FastAPIUploadFile]
-) -> None:
-    """Validate sizes of files in batch
-
-    Args:
-        user_id (str): The user ID
-        files (list[FastAPIUploadFile]): The files to validate
-
-    Raises:p
-        HTTPException: If the file size is too large
-    """
-    total_batch_size = 0
-    for file in files:
-        if file.size > MAX_FILE_SIZE:
-            raise HTTPException(
-                status_code=400,
-                detail=f"{file.filename} exceeds the maximum allowed size of {MAX_FILE_SIZE} bytes.",
-            )
-        total_batch_size += file.size
-
-    existing_files = file_crud.get_files_by_user_id(session, user_id)
-    total_file_size = sum([f.file_size for f in existing_files]) + total_batch_size
-
-    if total_file_size > MAX_TOTAL_FILE_SIZE:
-        raise HTTPException(
-            status_code=400,
-            detail=f"Total file size exceeds the maximum allowed size of {MAX_TOTAL_FILE_SIZE} bytes.",
-        )

src/backend/tests/unit/routers/test_conversation.py

@@ -12,7 +12,7 @@
     Message,
 )
 from backend.schemas.user import User
-from backend.services.file import MAX_FILE_SIZE, MAX_TOTAL_FILE_SIZE, get_file_service
+from backend.services.file import get_file_service
 from backend.tests.unit.factories import get_factory
 
 
@@ -594,73 +594,6 @@ def test_batch_upload_file_existing_conversation(
     assert len(files_stored) == len(file_paths)
 
 
-def test_batch_upload_total_files_exceeds_limit(
-    session_client: TestClient, session: Session, user, mock_compass_settings
-) -> None:
-    _ = get_factory("Conversation", session).create(user_id=user.id)
-    file_paths = {
-        "Mariana_Trench.pdf": "src/backend/tests/unit/test_data/Mariana_Trench.pdf",
-        "Cardistry.pdf": "src/backend/tests/unit/test_data/Cardistry.pdf",
-        "Tapas.pdf": "src/backend/tests/unit/test_data/Tapas.pdf",
-        "Mount_Everest.pdf": "src/backend/tests/unit/test_data/Mount_Everest.pdf",
-    }
-    files = [
-        ("files", (file_name, open(file_path, "rb")))
-        for file_name, file_path in file_paths.items()
-    ]
-
-    conversation = get_factory("Conversation", session).create(user_id=user.id)
-    file = get_factory("File", session).create(
-        file_name="test_file.txt",
-        user_id=conversation.user_id,
-        file_size=1000000000,
-    )
-    _ = get_factory("ConversationFileAssociation", session).create(
-        conversation_id=conversation.id, user_id=user.id, file_id=file.id
-    )
-
-    response = session_client.post(
-        "/v1/conversations/batch_upload_file",
-        files=files,
-        headers={"User-Id": conversation.user_id},
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "detail": f"Total file size exceeds the maximum allowed size of {MAX_TOTAL_FILE_SIZE} bytes."
-    }
-
-
-def test_batch_upload_single_file_exceeds_limit(
-    session_client: TestClient, session: Session, user, mock_compass_settings
-) -> None:
-    _ = get_factory("Conversation", session).create(user_id=user.id)
-    file_paths = {
-        "Mariana_Trench.pdf": "src/backend/tests/unit/test_data/Mariana_Trench.pdf",
-        "Cardistry.pdf": "src/backend/tests/unit/test_data/Cardistry.pdf",
-        "26mb.pdf": "src/backend/tests/unit/test_data/26mb.pdf",
-        "Tapas.pdf": "src/backend/tests/unit/test_data/Tapas.pdf",
-        "Mount_Everest.pdf": "src/backend/tests/unit/test_data/Mount_Everest.pdf",
-    }
-    files = [
-        ("files", (file_name, open(file_path, "rb")))
-        for file_name, file_path in file_paths.items()
-    ]
-
-    conversation = get_factory("Conversation", session).create(user_id=user.id)
-
-    response = session_client.post(
-        "/v1/conversations/batch_upload_file",
-        files=files,
-        headers={"User-Id": conversation.user_id},
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "detail": f"26mb.pdf exceeds the maximum allowed size of {MAX_FILE_SIZE} bytes."
-    }
-
-
 def test_batch_upload_file_nonexistent_conversation_creates_new_conversation(
     session_client: TestClient, session: Session, user, mock_compass_settings
 ) -> None: