Skip to content

Conversation

DominikPeters
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2025

CLA assistant check
All committers have signed the CLA.

@jGaboardi jGaboardi mentioned this pull request Jun 11, 2025
@tkralphs
Copy link
Member

I'll merge this as soon as tests pass. I guess that CI is waiting on the CLA being signed? It's a trivial change so a CLA is probably not technically needed, but it's not easy to bypass it.

@tkralphs
Copy link
Member

I could also probably just create a duplicate PR myself.

@DominikPeters
Copy link
Contributor Author

Hi, sorry I forgot about this, I just signed the CLA.

@DominikPeters DominikPeters marked this pull request as ready for review August 20, 2025 16:23
@tkralphs tkralphs requested review from tuliotoffolo and h-g-s August 22, 2025 16:48
@tkralphs
Copy link
Member

I'm probably missing something obvious, but I'm not sure why the CI is not running here.

@tkralphs
Copy link
Member

Well, there are a lot of failures, but they mostly seem to be related to problems with the Highs interface, not due to the PR, so I will just go ahead and merge this. It would be great if someone could address some of these failures in another PR.

@tkralphs tkralphs merged commit 45f60c0 into coin-or:master Aug 27, 2025
11 of 42 checks passed
@rschwarz
Copy link
Contributor

It would be great if someone could address some of these failures in another PR.

We did fix some bugs in the HiGHS interface, but the PR (#405) didn't get any attention back then, so we have added further changes to a fork at https://github.com/Doing-The-Math/python-mip.

I could create another PR with all of these, but it would be worth reviewing them, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants