Skip to content

Commit 981ab48

Browse files
authored
Merge pull request #338 from GeekArthur/updateCompileScript
Update compile script and instruction
2 parents 862bbda + ef16096 commit 981ab48

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,15 @@ While working on improvements to this repository, we recommend that you use thes
8989
* `make release` to run one last check before opening a PR
9090
* `make compile version=RELEASE_TAG` to generate binaries
9191

92-
If you are developing on both the `rosetta-cli` and `rosetta-sdk-go` repositories, use [go.mod replace](https://golang.org/ref/mod#go-mod-file-replace) to reference local changes:
92+
If you are developing on both the `rosetta-cli` and `rosetta-sdk-go` repositories, use [go.mod replace](https://golang.org/ref/mod#go-mod-file-replace) to reference local changes:
9393
```
94-
replace "github.com/coinbase/rosetta-sdk-go" v0.6.8 => "../rosetta-sdk-go"
94+
replace "github.com/coinbase/rosetta-sdk-go" v0.6.8 => "<PATH TO LOCAL rosetta-sdk-go>"
9595
```
96-
## Release
97-
* When we release a new rosetta-cli version, please update the [version number](https://github.com/coinbase/rosetta-cli/blob/master/cmd/root.go#L297) so that `rosetta-cli version` command can print the correct value.
98-
* Create binaries and upload all the binaries in the new release tag (Eg: https://github.com/coinbase/rosetta-cli/releases/tag/v0.7.7)
99-
* `make compile version=<New Version>`
96+
### Release
97+
* When we release a new rosetta-cli version, please update the version number to follow [PR](https://github.com/coinbase/rosetta-cli/pull/334) so that `rosetta-cli version` command can print the correct value.
98+
* Create binaries and upload all the binaries in the new release tag (e.g. https://github.com/coinbase/rosetta-cli/releases/tag/v0.7.7)
99+
* Ensure `$GOPATH/bin` is added to `$PATH`
100+
* Run `make compile version=<New Version>`
100101
* All the binaries will be created in the `bin` folder and should have extension as `tar.gz` and new version number
101102

102103
### Helper/Handler

scripts/compile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
VERSION=$1;
1818

19-
go get github.com/crazy-max/xgo
19+
go install github.com/crazy-max/xgo@latest
2020

2121
MAC_TARGETS="darwin/amd64,darwin/arm64"
2222
LINUX_TARGETS="linux/amd64,linux/arm64,linux/mips64,linux/mips64le,linux/ppc64le,linux/s390x"

0 commit comments

Comments
 (0)