Improved View logic + re-arrange core files + more unit tests

Author: coinbump

PhaseJumpPro/Assets/Examples/Matrix2D Examples/Checkers Example/Prefabs/ck-square-dark-prefab.prefab

@@ -124,6 +124,25 @@ BoxCollider2D:
   m_Enabled: 1
   m_Density: 1
   m_Material: {fileID: 0}
+  m_IncludeLayers:
+    serializedVersion: 2
+    m_Bits: 0
+  m_ExcludeLayers:
+    serializedVersion: 2
+    m_Bits: 0
+  m_LayerOverridePriority: 0
+  m_ForceSendLayers:
+    serializedVersion: 2
+    m_Bits: 4294967295
+  m_ForceReceiveLayers:
+    serializedVersion: 2
+    m_Bits: 4294967295
+  m_ContactCaptureLayers:
+    serializedVersion: 2
+    m_Bits: 4294967295
+  m_CallbackLayers:
+    serializedVersion: 2
+    m_Bits: 4294967295
   m_IsTrigger: 1
   m_UsedByEffector: 0
   m_UsedByComposite: 0

PhaseJumpPro/Assets/Examples/Matrix2D Examples/Life Example/Scripts/ELFMatrixView.cs

@@ -100,7 +100,7 @@ protected ELFSimAgent AgentAt(Vector2Int location)
         return null;
     }
 
-    public override void OnPointerClickEvent(PointerClickUIEvent _event)
+    public override void OnPointerClickEvent(PointerClickUIEvent<LocalPosition> _event)
     {
         var localPressPosition = _event.pressPosition;
         var cellHit = LocationAtLocalPosition(localPressPosition.Position);

PhaseJumpPro/Assets/Examples/Matrix2D Examples/Mine Sweeper Example/Scripts/EMSBoardView.cs

@@ -98,7 +98,7 @@ protected void PopulateBoard()
         ClearTilesAt(emptyCells[0]);
     }
 
-    public override void OnPointerClickEvent(PointerClickUIEvent _event)
+    public override void OnPointerClickEvent(PointerClickUIEvent<LocalPosition> _event)
     {
         var localPressPosition = _event.pressPosition;
         var cellHit = LocationAtLocalPosition(localPressPosition.Position);
@@ -108,9 +108,9 @@ public override void OnPointerClickEvent(PointerClickUIEvent _event)
         var cellGameObject = WorldNodeAt(cellHit.value);
         var hitTile = cellGameObject.GetComponent<EMSTile>();
 
-        switch (_event.button)
+        switch (_event.Button)
         {
-            case PointerClickUIEvent.InputButton.Left:
+            case PointerInputButton.Left:
                 {
                     switch (core.State)
                     {
@@ -130,7 +130,7 @@ public override void OnPointerClickEvent(PointerClickUIEvent _event)
                     }
                     break;
                 }
-            case PointerClickUIEvent.InputButton.Right:
+            case PointerInputButton.Right:
                 {
                     switch (hitTile.type)
                     {

PhaseJumpPro/Assets/Examples/Misc Examples/Emitter3D Example/example-emitter3D.mat

@@ -12,7 +12,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: d0353a89b1f911e48b9e16bdc9f2e058, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
-  version: 5
+  version: 7
 --- !u!21 &2100000
 Material:
   serializedVersion: 8
@@ -22,6 +22,8 @@ Material:
   m_PrefabAsset: {fileID: 0}
   m_Name: example-emitter3D
   m_Shader: {fileID: 4800000, guid: 933532a4fcc9baf4fa0491de14d08ed7, type: 3}
+  m_Parent: {fileID: 0}
+  m_ModifiedSerializedProperties: 0
   m_ValidKeywords:
   - _EMISSION
   - _SPECULAR_SETUP
@@ -33,6 +35,7 @@ Material:
   stringTagMap:
     RenderType: Opaque
   disabledShaderPasses: []
+  m_LockedProperties: 
   m_SavedProperties:
     serializedVersion: 3
     m_TexEnvs:

PhaseJumpPro/Assets/Settings/Renderer2D.asset

@@ -14,6 +14,7 @@ MonoBehaviour:
   m_EditorClassIdentifier: 
   debugShaders:
     debugReplacementPS: {fileID: 4800000, guid: cf852408f2e174538bcd9b7fda1c5ae7, type: 3}
+    hdrDebugViewPS: {fileID: 4800000, guid: 573620ae32aec764abd4d728906d2587, type: 3}
   m_RendererFeatures: []
   m_RendererFeatureMap: 
   m_UseNativeRenderPass: 0
@@ -44,7 +45,9 @@ MonoBehaviour:
   m_ShapeLightVolumeShader: {fileID: 4800000, guid: 7e60080c8cd24a2468cb08b4bfee5606, type: 3}
   m_PointLightShader: {fileID: 4800000, guid: e35a31e1679aeff489e202f5cc4853d5, type: 3}
   m_PointLightVolumeShader: {fileID: 4800000, guid: c7d04ca57e5449d49ad9cee1c604bc26, type: 3}
-  m_BlitShader: {fileID: 4800000, guid: c17132b1f77d20942aa75f8429c0f8bc, type: 3}
+  m_CoreBlitShader: {fileID: 4800000, guid: 93446b5c5339d4f00b85c159e1159b7c, type: 3}
+  m_BlitHDROverlay: {fileID: 4800000, guid: a89bee29cffa951418fc1e2da94d1959, type: 3}
+  m_CoreBlitColorAndDepthPS: {fileID: 4800000, guid: d104b2fc1ca6445babb8e90b0758136b, type: 3}
   m_SamplingShader: {fileID: 4800000, guid: 04c410c9937594faa893a11dceb85f7e, type: 3}
   m_ProjectedShadowShader: {fileID: 4800000, guid: ce09d4a80b88c5a4eb9768fab4f1ee00, type: 3}
   m_SpriteShadowShader: {fileID: 4800000, guid: 44fc62292b65ab04eabcf310e799ccf6, type: 3}

PhaseJumpPro/Assets/Settings/UniversalRP.asset

@@ -12,8 +12,8 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: bf2edee5c58d82540a51f03df9d42094, type: 3}
   m_Name: UniversalRP
   m_EditorClassIdentifier: 
-  k_AssetVersion: 9
-  k_AssetPreviousVersion: 9
+  k_AssetVersion: 11
+  k_AssetPreviousVersion: 11
   m_RendererType: 1
   m_RendererData: {fileID: 0}
   m_RendererDataList:
@@ -24,13 +24,16 @@ MonoBehaviour:
   m_RequireOpaqueTexture: 0
   m_OpaqueDownsampling: 1
   m_SupportsTerrainHoles: 1
-  m_StoreActionsOptimization: 0
   m_SupportsHDR: 1
+  m_HDRColorBufferPrecision: 0
   m_MSAA: 1
   m_RenderScale: 1
   m_UpscalingFilter: 0
   m_FsrOverrideSharpness: 0
   m_FsrSharpness: 0.92
+  m_EnableLODCrossFade: 1
+  m_LODCrossFadeDitheringType: 1
+  m_ShEvalMode: 0
   m_MainLightRenderingMode: 1
   m_MainLightShadowsSupported: 1
   m_MainLightShadowmapResolution: 2048
@@ -55,13 +58,17 @@ MonoBehaviour:
   m_SoftShadowsSupported: 0
   m_ConservativeEnclosingSphere: 0
   m_NumIterationsEnclosingSphere: 64
+  m_SoftShadowQuality: 2
   m_AdditionalLightsCookieResolution: 2048
   m_AdditionalLightsCookieFormat: 3
   m_UseSRPBatcher: 1
   m_SupportsDynamicBatching: 0
   m_MixedLightingSupported: 1
+  m_SupportsLightCookies: 1
   m_SupportsLightLayers: 0
   m_DebugLevel: 0
+  m_StoreActionsOptimization: 0
+  m_EnableRenderGraph: 0
   m_UseAdaptivePerformance: 1
   m_ColorGradingMode: 0
   m_ColorGradingLutSize: 32
@@ -71,6 +78,33 @@ MonoBehaviour:
   m_LocalShadowsAtlasResolution: 256
   m_MaxPixelLights: 0
   m_ShadowAtlasResolution: 256
-  m_ShaderVariantLogLevel: 0
   m_VolumeFrameworkUpdateMode: 0
+  m_Textures:
+    blueNoise64LTex: {fileID: 2800000, guid: e3d24661c1e055f45a7560c033dbb837, type: 3}
+    bayerMatrixTex: {fileID: 2800000, guid: f9ee4ed84c1d10c49aabb9b210b0fc44, type: 3}
+  m_PrefilteringModeMainLightShadows: 1
+  m_PrefilteringModeAdditionalLight: 4
+  m_PrefilteringModeAdditionalLightShadows: 1
+  m_PrefilterXRKeywords: 0
+  m_PrefilteringModeForwardPlus: 1
+  m_PrefilteringModeDeferredRendering: 1
+  m_PrefilteringModeScreenSpaceOcclusion: 1
+  m_PrefilterDebugKeywords: 0
+  m_PrefilterWriteRenderingLayers: 0
+  m_PrefilterHDROutput: 0
+  m_PrefilterSSAODepthNormals: 0
+  m_PrefilterSSAOSourceDepthLow: 0
+  m_PrefilterSSAOSourceDepthMedium: 0
+  m_PrefilterSSAOSourceDepthHigh: 0
+  m_PrefilterSSAOInterleaved: 0
+  m_PrefilterSSAOBlueNoise: 0
+  m_PrefilterSSAOSampleCountLow: 0
+  m_PrefilterSSAOSampleCountMedium: 0
+  m_PrefilterSSAOSampleCountHigh: 0
+  m_PrefilterDBufferMRT1: 0
+  m_PrefilterDBufferMRT2: 0
+  m_PrefilterDBufferMRT3: 0
+  m_PrefilterScreenCoord: 0
+  m_PrefilterNativeRenderPass: 0
+  m_ShaderVariantLogLevel: 0
   m_ShadowCascades: 0

PhaseJumpPro/Assets/UniversalRenderPipelineGlobalSettings.asset

@@ -12,7 +12,17 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: 2ec995e51a6e251468d2a3fd8a686257, type: 3}
   m_Name: UniversalRenderPipelineGlobalSettings
   m_EditorClassIdentifier: 
-  k_AssetVersion: 2
+  k_AssetVersion: 3
+  m_RenderingLayerNames:
+  - Light Layer default
+  - Light Layer 1
+  - Light Layer 2
+  - Light Layer 3
+  - Light Layer 4
+  - Light Layer 5
+  - Light Layer 6
+  - Light Layer 7
+  m_ValidRenderingLayers: 255
   lightLayerName0: Light Layer default
   lightLayerName1: Light Layer 1
   lightLayerName2: Light Layer 2
@@ -24,4 +34,8 @@ MonoBehaviour:
   m_StripDebugVariants: 1
   m_StripUnusedPostProcessingVariants: 0
   m_StripUnusedVariants: 1
+  m_StripUnusedLODCrossFadeVariants: 1
+  m_StripScreenCoordOverrideVariants: 1
   supportRuntimeDebugDisplay: 0
+  m_ShaderVariantLogLevel: 0
+  m_ExportShaderVariants: 1

PhaseJumpPro/Assets/phasejumppro/Animation/SomeAnimation.cs

@@ -15,18 +15,18 @@ public abstract class SomeAnimation : WorldComponent
     {
         public MeshMaterialType meshMaterialType = MeshMaterialType.Copy;
 
-        private MultiRenderer multiRenderer;
+        private RendererTool rendererTool;
 
-        protected MultiRenderer MultiRenderer
+        protected RendererTool MultiRenderer
         {
             get
             {
-                if (null == multiRenderer)
+                if (null == rendererTool)
                 {
-                    multiRenderer = new(gameObject);
-                    multiRenderer.meshMaterialType = meshMaterialType;
+                    rendererTool = new(gameObject);
+                    rendererTool.meshMaterialType = meshMaterialType;
                 }
-                return multiRenderer;
+                return rendererTool;
             }
         }
     }

PhaseJumpPro/Assets/phasejumppro/Core/AnyFactory.cs

@@ -1,7 +1,7 @@
 /*
  * RATING: 5 stars
  * Abstract
- * CODE REVIEW: 1/14/23
+ * CODE REVIEW: 6/8/23
  * PORTED TO: C++
  */
 namespace PJ

…asejumppro/Interface/SomeEventHandler.cs …ppro/Core/Components/SomeEventHandler.csPhaseJumpPro/Assets/phasejumppro/Interface/SomeEventHandler.cs renamed to PhaseJumpPro/Assets/phasejumppro/Core/Components/SomeEventHandler.cs PhaseJumpPro/Assets/phasejumppro/Interface/SomeEventHandler.cs renamed to PhaseJumpPro/Assets/phasejumppro/Core/Components/SomeEventHandler.cs

@@ -2,10 +2,15 @@
 using UnityEngine;
 using PJ;
 
+/*
+RATING: 5 stars
+Simple type
+CODE REVIEW: 6/10/23
+*/
 namespace PJ
 {
     /// <summary>
-    /// Responds to events (similar to SomeListener)
+    /// A component that listens to events
     /// </summary>
     public abstract class SomeEventHandler : WorldComponent, SomeListener
     {